Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C-CUSTOM-TYPE: these may be okay but we should be mindful of future changes (device-specific timeout options, 10-bit addresses) #2786

Open
Tracked by #2493
bugadani opened this issue Dec 13, 2024 · 1 comment
Labels
Milestone

Comments

@bugadani
Copy link
Contributor

bugadani commented Dec 13, 2024

  • timeout field in Config is an Option
  • address parameter in write, read, write_read and transaction is a u8
@bjoernQ
Copy link
Contributor

bjoernQ commented Dec 17, 2024

👍 for address we definitely can't keep u8 - should we do it like embedded-hal and have it <A: AddressMode = SevenBitAddress> or have an enum? Enum would be more explicit but also more annoying - and implementing the embedded-hal traits might be annoying

Not sure about timeout - given the docs already need to explain the different behavior of None depending on the target device this might call for being more explicit (the u32 already made users wonder what the unit of measurement is)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

3 participants