Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C-VALIDATE #2787

Open
Tracked by #2493
bugadani opened this issue Dec 13, 2024 · 1 comment
Open
Tracked by #2493

C-VALIDATE #2787

bugadani opened this issue Dec 13, 2024 · 1 comment
Labels
1.0-blocker peripheral:i2c I2C peripheral

Comments

@bugadani
Copy link
Contributor

bugadani commented Dec 13, 2024 •
edited
Loading

write, read, write_read and transaction do not validate the address
@bugadani bugadani mentioned this issue Dec 13, 2024
Open
38 tasks
@tom-borcin tom-borcin added the investigation Not needed for 1.0, but don't know if we can support without breaking the driver. label Dec 16, 2024
@MabezDev
Copy link
Member

Given that write, read, write_read and transaction all return errors, we can add this validation in an API compatible way at any time. However, we should do this for 1.0 for the sake of usability.

@MabezDev MabezDev removed the investigation Not needed for 1.0, but don't know if we can support without breaking the driver. label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0-blocker peripheral:i2c I2C peripheral
Projects
esp-rs
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bugadani @MabezDev @tom-borcin