Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't run CI on main #3066

Closed
MabezDev opened this issue Jan 30, 2025 · 2 comments
Closed

Don't run CI on main #3066

MabezDev opened this issue Jan 30, 2025 · 2 comments
Assignees
@playfulFence
Labels
CI Continuous integration/deployment
Milestone
1.0.0-beta.1

Comments

@MabezDev
Copy link
Member

We already do all the merge checks in the merge queue.
@MabezDev MabezDev added the CI Continuous integration/deployment label Jan 30, 2025
@MabezDev MabezDev added this to the 1.0.0-beta.1 milestone Jan 30, 2025
@playfulFence playfulFence self-assigned this Jan 30, 2025
@jessebraham
Copy link
Member

jessebraham commented Feb 5, 2025 •
edited
Loading

I don't think this is an issue anymore, it seems GitHub have made some changes on their end. The latest PR which was merged shows green just minutes after merging (so not long enough for the workflow to complete), and the workflow status points to the merge_group check, so it seems it's just run for the PR and merge queue now.

@MabezDev
Copy link
Member Author

MabezDev commented Feb 5, 2025 •
edited
Loading

It's nice to not have to do anything to close an issue every once in while :D

@MabezDev MabezDev closed this as completed Feb 5, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@playfulFence playfulFence

Labels
CI Continuous integration/deployment
Projects
esp-rs
Archived in project
Milestone
1.0.0-beta.1
Development

No branches or pull requests
3 participants
@jessebraham @MabezDev @playfulFence