Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The embassy_serial example seems to be broken #850

Closed
jessebraham opened this issue Oct 16, 2023 · 2 comments · Fixed by #871
Closed

The embassy_serial example seems to be broken #850

jessebraham opened this issue Oct 16, 2023 · 2 comments · Fixed by #871
Assignees
Labels
bug Something isn't working

Comments

@jessebraham
Copy link
Member

This was confirmed on ESP32, possibly affects other chips. Needs more investigation.

@jessebraham jessebraham added the bug Something isn't working label Oct 16, 2023
@bjoernQ
Copy link
Contributor

bjoernQ commented Oct 17, 2023

Looking into it, it might do what the code says. It's just a slightly weird example

Also it's not correct to return a len of 0 if there is no data to receive ( https://docs.rs/embedded-io-async/0.6.0/embedded_io_async/trait.Read.html#tymethod.read )

@elpiel
Copy link
Contributor

elpiel commented Oct 22, 2023

Yes, it's correct. Receiving over UART is currently not working for ESP32-C3 as well.

PS: Please consider dumping the UART received data in the example as it's not that clear what happens in the receive loop.

@bjoernQ bjoernQ assigned bjoernQ and unassigned bjoernQ Oct 25, 2023
@MabezDev MabezDev self-assigned this Oct 25, 2023
@MabezDev MabezDev mentioned this issue Oct 25, 2023
8 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants