Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove riscv::interrupt::enable() from the examples #924

Closed
bjoernQ opened this issue Nov 10, 2023 · 1 comment · Fixed by #936
Closed

Remove riscv::interrupt::enable() from the examples #924

bjoernQ opened this issue Nov 10, 2023 · 1 comment · Fixed by #936

Comments

@bjoernQ
Copy link
Contributor

bjoernQ commented Nov 10, 2023

Most/many/some interrupt related examples contain riscv::interrupt::enable() - this is confusing to users and unnecessary. We should get rid of that
@jessebraham
Copy link
Member

Thanks for this, I noticed that as well a couple weeks ago but forgot to open an issue for it 😅

@bjoernQ bjoernQ mentioned this issue Nov 14, 2023
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
esp-rs
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary riscv::interrupt::enable() from examples bjoernQ/esp-hal
2 participants
@jessebraham @bjoernQ