-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement rand traits for Rng #942
Comments
Looking at Espressif's documentation about the ESP32 RNG, I learnt that the system has one random number generator, that produces randomness of different quality depending on conditions:
Hence, the
|
I guess the first option is better since the behavior for the second option might be somewhat surprising. (We could have it in the docs but often people only look into the docs if something isn't working as expected) |
We have implemented the necessary trait(s) in #1122, however (as is already documented) we have not met the necessary preconditions to produce true random numbers. Should we consider this issue closed regardless, or should we keep it open until this changes? I think it's fine to close, but just want to double-check with others. |
however (as is already documented) we have not met the necessary preconditions to produce _true_ random numbers. Should we consider this issue closed regardless, or should we keep it open until this changes? I think it's fine to close, but just want to double-check with others.
AIUI, that means the CryptoRng trait should not be implemented now, only Rng should be implemented now.
This issue should be closed IMHO, and a follow-up issue to implement CryptoRng should be opened.
|
In order to use the hardware RNG with external code that accepts implementations of
RngCore
andCryptoRng
, these traits should be implemented for theRng
struct.The text was updated successfully, but these errors were encountered: