Skip to content

Commit aeaf050

Browse files
committed
fix(mdns): Fix potential mem issue with scheduled packets
Closes #917
1 parent 18f0d02 commit aeaf050

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

components/mdns/mdns.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2287,17 +2287,13 @@ static void _mdns_init_pcb_probe_new_service(mdns_if_t tcpip_if, mdns_ip_protoco
22872287

22882288
probe_ip = pcb->probe_ip || probe_ip;
22892289

2290-
pcb->probe_ip = false;
2291-
pcb->probe_services = NULL;
2292-
pcb->probe_services_len = 0;
2293-
pcb->probe_running = false;
2294-
22952290
mdns_tx_packet_t *packet = _mdns_create_probe_packet(tcpip_if, ip_protocol, _services, services_final_len, true, probe_ip);
22962291
if (!packet) {
22972292
mdns_mem_free(_services);
22982293
return;
22992294
}
23002295

2296+
// Only clear the PCB state after we know the packet creation succeeded
23012297
pcb->probe_ip = probe_ip;
23022298
pcb->probe_services = _services;
23032299
pcb->probe_services_len = services_final_len;

0 commit comments

Comments
 (0)