Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better name for esp_zb_main_loop_iteration() (TZ-916) #356

Closed
Rob190 opened this issue Jun 5, 2024 · 2 comments
Closed

Better name for esp_zb_main_loop_iteration() (TZ-916) #356

Rob190 opened this issue Jun 5, 2024 · 2 comments

Comments

@Rob190
Copy link

Rob190 commented Jun 5, 2024

Is your feature request related to a problem?

It appears esp_zb_main_loop_iteration() doesn't actually perform a single iteration as the name would suggest, but instead wraps a while-true loop which calls zboss_main_loop_iteration() on each iteration of the loop. This is completely counter-intuitive and I spent many hours trying to figure out how to use esp_zb_main_loop_iteration() before someone kindly pointed out it was simply a poor choice of name:

https://esp32.com/viewtopic.php?f=22&t=40119&p=133104#p133104

Describe the solution you'd like.

A better name for esp_zb_main_loop_iteration() e.g. esp_zb_main_loop()

Describe alternatives you've considered.

Probably I would define my own wrapper for zboss_main_loop_iteration(). I have an aversion to misleading names appearing in code I have to support.

Additional context.

No response

@github-actions github-actions bot changed the title Better name for esp_zb_main_loop_iteration() Better name for esp_zb_main_loop_iteration() (TZ-916) Jun 5, 2024
@chshu
Copy link
Collaborator

chshu commented Jun 12, 2024

Sounds reasonable, we will rename it.

@xieqinan
Copy link
Contributor

@Rob190,

The esp_zb_main_loop_iteration() has been deprecated in esp-zigbee-sdk v1.5.0, please use the esp_zb_stack_main_loop() instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants