Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VSC-1558] Add --make argument #1403

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

radurentea
Copy link
Collaborator

Description

Added new argument --make when starting monitoring, so that keyboard shortcuts for quick build & flash will work

Fixes #1400

Type of change

  • New feature (non-breaking change which adds functionality)

Steps to test this pull request

  • Build some project and flash it

  • Open ESP-IDF Monitor from bottom toolbar

  • Focus on Monitor and click Ctrl+T followed by a Ctrl+A to trigger "Build and flash the app only" which should pause the monitor, run build and re-flash the app.

  • Expected behaviour:

Should pause the monitor, run build and re-flash the app.

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

As described above

Test Configuration:

  • ESP-IDF Version: 5.4
  • OS (Windows,Linux and macOS): Windows 11

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

This argument make shortcuts work while monitoring
@radurentea radurentea self-assigned this Jan 16, 2025
Copy link

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

@brianignacio5 brianignacio5 added this to the v1.9.1 milestone Jan 20, 2025
@Fabricio-ESP
Copy link
Collaborator

Confirmed working on Windows 11, Ubuntu24 and MacOS15.
Was ablet o rebuild and flash an example project to the target from the monitor terminal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDF Monitor shortcuts do not work (VSC-1558)
3 participants