trigger modes do not work for Balor (maybe only Zyla?)

[pjb671]

The enumerated trigger modes do not apply for the Andor Balor
https://github.com/esrf-bliss/Lima-camera-andor3/blob/master/include/Andor3Camera.h#L73

enum A3_TriggerMode { Internal = 0, ExternalLevelTransition = 1, ExternalStart = 2, ExternalExposure = 3, Software = 4, Advanced = 5, External = 6 };

These work for the Zyla (for example) but for the Balor the options in the SDK would be

enum A3_TriggerMode { Internal = 0, Software = 1, External = 2, ExternalStart = 3, ExternalExposure = 4 }

As it is, if one selects EXTERNAL_TRIGGER_MULTI in Lima for the Balor, the check here https://github.com/esrf-bliss/Lima-camera-andor3/blob/master/src/Andor3Camera.cpp#L1411 is failed since the SDK expects 2 not 6.

[laurent-claustre]

Hi,
yes, we knowm with new cameras like Balor or Marana, the enums are completely screwed up.
We are working on this to refactor the code using the SDK introspection functions to be less depending on the camera models. We are now working using the SDK version 3.14.
Thanks for your feedback.

[pjb671]

Hi,
Thanks for your reply, its Paul at MAX IV by the way, I only just noticed my very old alias name here. We are not blocked here because we hacked it locally as a work around for the beamline, but its not a proper fix as the Balor only has modes 0-4, ExternalLevelTransition and Advanced do not apply but are still defined. Do you have an estimate when the refactoring might be done?
Best regards,
Paul

[laurent-claustre]

Hi Paul,
we're working on the Marana model and it seems some beamlines will be equipped soon with a Balor one as well. So it becomes urgent to us to improve the code. Work can be done before summer.

[laurent-claustre]

@manupapillon