-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add native image handler backend #497
base: main
Are you sure you want to change the base?
Conversation
This change adds a new native backend to remove eventually the need to depend on external skopeo binary. Using the native library allows much better control and error handling. It also enables us to add more easily new features like signing for example. * Migrate image inspect and copy into a interface * Migrate skopeo based calls into new package * Remove code duplication in registries * Add cache layer backend * Add new optional alternative native image backend
|
It might need extra build tags to fix the gpgme dependency: https://github.com/containers/image#supported-build-tags |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #497 +/- ##
==========================================
+ Coverage 34.08% 36.89% +2.81%
==========================================
Files 9 10 +1
Lines 848 786 -62
==========================================
+ Hits 289 290 +1
+ Misses 534 471 -63
Partials 25 25
☔ View full report in Codecov by Sentry. |
One central place to handle caching
a28b775
to
c9d2d29
Compare
2f07fd6
to
eec3136
Compare
add back secret to gh action
This reverts commit 1cf14ac.
Hello @estahn, Wdyt of this PR ? Anything needed ? |
@project0 Apologies it took me so long to look at things. Could you resolve the conflicting files? I tried, but there are some changes in |
This change adds a new native backend to remove eventually the need to depend on external skopeo binary.
Using the native library allows much better control and error handling. It also enables us to add more easily new features like signing for example.
implements #443