Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests against installed package #32

Open
bryphe opened this issue Oct 31, 2018 · 3 comments
Open

Run tests against installed package #32

bryphe opened this issue Oct 31, 2018 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@bryphe
Copy link
Collaborator

bryphe commented Oct 31, 2018

We seem some failures due to the unpacking / packing logic (for example, symlinks not being hydrated correctly).

We should run our test suite against the install package, too. We could do an additional run after we've packed and specify the esy-bash root location via an environment variable.

@bryphe bryphe added the help wanted Extra attention is needed label Oct 31, 2018
@bryphe
Copy link
Collaborator Author

bryphe commented Oct 31, 2018

An example of a failure that would be caught by tests like these is: #33

@bryphe
Copy link
Collaborator Author

bryphe commented Nov 1, 2018

This a little awkward to do in AppVeyor at the moment, because we publish in our deploy_script block - we could potentially move that logic to the build step, and run the tests after. This is still awkward because we'd be running tests after potentially publishing the package.

Alternatively, we could:

  • npm pack
  • npm install the tgz to a separate directory
  • run tests against that separate directory
  • delete the tgz

@andreypopp
Copy link
Member

Installing with npm pack && npm install seems like the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants