marker(markdown linter): use released binary when running markdown lint #18318
Conversation
The markdown linter, marker, now publishes a released version with the tool. Given that this project is written in Rust, running this check can now be done by using the statically compiled binary without having the Rust local environment. Signed-off-by: Ivan Valdes <[email protected]>
|
This enables this linter to work on the prow infrastructure. Refer to: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/etcd-io_etcd/18318/pull-etcd-verify/1812260372736905216#1:build-log.txt%3A649-653 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 19 files with indirect coverage changes @@ Coverage Diff @@
## main #18318 +/- ##
=======================================
Coverage 69.00% 69.00%
=======================================
Files 417 417
Lines 35332 35332
=======================================
Hits 24380 24380
+ Misses 9540 9537 -3
- Partials 1412 1415 +3 Continue to review full report in Codecov by Sentry.
|
|
/retest |
| generic_checker run marker --skip-http --allow-absolute-paths --root "${ETCD_ROOT_DIR}" -e ./CHANGELOG -e ./etcdctl -e etcdutl -e ./tools 2>&1 | ||
| if ! tool_exists "$marker" "https://crates.io/crates/marker"; then | ||
| log_callout "Installing markdown marker $MARKDOWN_MARKER_VERSION" | ||
| wget -qO- "https://github.com/crawford/marker/releases/download/${MARKDOWN_MARKER_VERSION}/marker-${MARKDOWN_MARKER_VERSION}-x86_64-unknown-linux-musl.tar.gz" | tar -xzv -C /tmp/ --strip-components=1 >/dev/null |
There was a problem hiding this comment.
You only download x86 version, I am curious why all the workflows running on arm64 also passed?
There was a problem hiding this comment.
This runs only on the pull-etcd-verify job, which doesn't run on arm64.
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ivanvc
changed the title
The markdown linter, marker, now publishes a released version with the tool. Given that this project is written in Rust, running this check can now be done by using the statically compiled binary without having the Rust local environment.
Part of #18059.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.