-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pika's transform_mpi
and polling support
#1125
Merged
Merged
Commits on Nov 6, 2024
-
Use pika's transform_mpi, polling modes
This is a squashed commit containing multiple changes completion_modes: pika supports different completion modes that may be used as an alternative to the dlaf:: transformMPI mechanism that uses yield_while to wait on an MPI request. The completion modes may be set via the environment variable PIKA_MPI_COMPLETION_MODE=<numeric value> which by default will select the one chosen by pika/dlaf developers known to give good results across a broad range of use cases. polling: The pika polling loop may test for one or multiple request completions on each iteration through the scheduling loop the environment var PIKA_MPI_POLLING_SIZE=<numeric value> (default 8) may be used to vary the polling size (typically the default value can be used without any need to play with this value) mpi pool: pika will create the mpi pool if the completion mode has the pool flag set, the user needs only to call the pool create function during the pika::init setup phase. Cleanup of the pool on shutdown will also be handled automatically The user should use pika::mpi::pool_name instead of raw "mpi", mpi pool management has been deferred tom pika::mpi Change: the transform mpi code does not need to return an MPI_SUCCESS value, the return value from mpi_transform has been removed to simplify code and an error is set using senders set_error if any mpi call fails. Should mpi_transform calls thnat return other value be required, this code can be reinstated.
Configuration menu - View commit details
-
Copy full SHA for 1b7a02c - Browse repository at this point
Copy the full SHA 1b7a02cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d1beb5b - Browse repository at this point
Copy the full SHA d1beb5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 88f2f13 - Browse repository at this point
Copy the full SHA 88f2f13View commit details -
Update dla mpi to use latest pika::mpi::experimental API
A series of changes to pika::mpi have changed both the API and the internal pool creation mechanism to simplify end user access to the transform_mpi features and setup of mpi polling itself.
Configuration menu - View commit details
-
Copy full SHA for eb87dce - Browse repository at this point
Copy the full SHA eb87dceView commit details -
Simplify init procedure as pika now uses command-line pool creation
latest pika:: transform_mpi is enabled/disabled via the command line and does not require explicit enabling via init_params
Configuration menu - View commit details
-
Copy full SHA for 929abd2 - Browse repository at this point
Copy the full SHA 929abd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76a4588 - Browse repository at this point
Copy the full SHA 76a4588View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb80d4b - Browse repository at this point
Copy the full SHA fb80d4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 572fd55 - Browse repository at this point
Copy the full SHA 572fd55View commit details
Commits on Nov 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 99ed7a1 - Browse repository at this point
Copy the full SHA 99ed7a1View commit details
Commits on Nov 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6f353e6 - Browse repository at this point
Copy the full SHA 6f353e6View commit details
Commits on Nov 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 43763dc - Browse repository at this point
Copy the full SHA 43763dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9921466 - Browse repository at this point
Copy the full SHA 9921466View commit details
Commits on Nov 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 069c764 - Browse repository at this point
Copy the full SHA 069c764View commit details -
Configuration menu - View commit details
-
Copy full SHA for 608c4b9 - Browse repository at this point
Copy the full SHA 608c4b9View commit details
Commits on Nov 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 238c1fb - Browse repository at this point
Copy the full SHA 238c1fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 226ebae - Browse repository at this point
Copy the full SHA 226ebaeView commit details -
Configuration menu - View commit details
-
Copy full SHA for be6ba17 - Browse repository at this point
Copy the full SHA be6ba17View commit details
Commits on Nov 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ca2c626 - Browse repository at this point
Copy the full SHA ca2c626View commit details
Commits on Nov 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3e0e45d - Browse repository at this point
Copy the full SHA 3e0e45dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f6af9bd - Browse repository at this point
Copy the full SHA f6af9bdView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.