Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consume CommunicatorPipelineSharedWrapper in transform_mpi #1218

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Consume CommunicatorPipelineSharedWrapper in transform_mpi #1218

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
494d6fd
consume also communicator shared wrapper in transform_mpi
albestro Nov 21, 2024
26acbd6
Update include/dlaf/sender/transform_mpi.h
albestro Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions include/dlaf/sender/transform_mpi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,18 @@

namespace dlaf::comm::internal {

/// This helper "consumes" a CommunicatorPipelineExclusiveWrapper ensuring that after this call
/// the one passed as argument gets destroyed. All other types left as they are
/// by the second overload.
/// This helper "consumes" a CommunicatorPipelineSharedWrapper or a CommunicatorPipelineSharedWrapper
albestro marked this conversation as resolved.
Show resolved Hide resolved
/// ensuring that after this call the one passed as argument gets destroyed. All other types left as they
/// are by the generic overload.
inline void consumeCommunicatorWrapper(CommunicatorPipelineExclusiveWrapper& comm_wrapper) {
[[maybe_unused]] auto comm_wrapper_local = std::move(comm_wrapper);
}

/// \overload consumeCommunicatorWrapper
inline void consumeCommunicatorWrapper(CommunicatorPipelineSharedWrapper& comm_wrapper) {
[[maybe_unused]] auto comm_wrapper_local = std::move(comm_wrapper);
}

/// \overload consumeCommunicatorWrapper
template <typename T>
void consumeCommunicatorWrapper(T&) {}
Expand Down
Loading