-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restart DLA-Future and the pika runtime less frequently in C API tests #1268
Conversation
cscs-ci run |
69a883f
to
8493b3f
Compare
cscs-ci run |
1 similar comment
cscs-ci run |
26abeba
to
2f154d0
Compare
cscs-ci run |
This does help quite a bit. In the last commit (26abeba) I only start and stop the runtime once per google-test. In the previous commit (70a69d9) I skip starting and stopping for the innermost loop but keep the others (it's still a good stress test, though not very realistic). My proposal would be to drop the last commit so we start and stop a bit less often, but still fairly often (this already gives quite a nice speedup). |
Already requesting reviews, or at least comments, on this. I would still need to update the other C API tests, I've only applied the change to the gen_eigensolver one so far. Waiting for comments before applying changes elsewhere. |
2f154d0
to
a000a10
Compare
I've rebased this on master instead of #1225, since it's not a requirement. |
Starting/stopping once per test sounds good to me (26abeba). I think at some point we already used this approach to avoid a memory leak in |
a000a10
to
53da3ae
Compare
cscs-ci run |
I've updated both eigensolver tests to restart DLAF/pika once per grid (we need the grid for init).
I don't remember for sure either, but I think it was to have a regression/unit test for the kind of issues that that mode exposed (memory leaks and other issues from restarting everything a lot of times), but I think we didn't consider the test time implications of it. |
No description provided.