RLP wiki page #232
Merged
RLP wiki page #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RLP wiki page
|
Hi @thogiti, Following typos were found in the pull request:
ℹ️ Here's how to fix them:
|
typos for wordlist is fixed
typos for wordlist is fixed
taxmeifyoucan
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Thanks for another piece of content @thogiti! I think we can merge it fast, just minor comments
Co-authored-by: Mário Havel <[email protected]>
Co-authored-by: Mário Havel <[email protected]>
Updated after the review
|
@taxmeifyoucan Updated for the changes. Thx. |
raxhvl
reviewed
Apr 29, 2024
| - **Condition**: If the input is a single byte string. | ||
| - **Encoding**: The byte is encoded directly, unchanged. | ||
| - **Example**: Encoding the byte `0x74` directly yields `0x74`. | ||
| - |
There was a problem hiding this comment.
Suggested change
| - | |
Extra bullet.
| - **Example**: Encoding the byte `0x2a` directly yields `0x2a`. | ||
|
|
||
| **Single Byte String Encoding** | ||
| - **Condition**: If the input is a single byte string. |
There was a problem hiding this comment.
The case above covers this single byte encoding correctly. I think this section can be removed.
- Condition: If the input is a single byte string.
- Encoding: The byte is encoded directly, unchanged.
This is incorrect. For the single byte 0x80 the encoding will not be the same. Rather 0x8180 . The section above bounds the input byte correctly.
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wiki PR Checklist