Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call for Input: Mark 7212 as "Moved" #345

Closed
9 tasks done
SamWilsn opened this issue Jul 3, 2024 · 11 comments
Closed
9 tasks done

Call for Input: Mark 7212 as "Moved" #345

SamWilsn opened this issue Jul 3, 2024 · 11 comments

Comments

@SamWilsn
Copy link
Collaborator

SamWilsn commented Jul 3, 2024

Call for Input

Decision

Do we merge ethereum/EIPs#8101 ?

If Affirmed

EIP-7212 is marked as "Moved", an unusual status.

If Rejected

Pull request is not merged, and 7212 remains both an EIP and an RIP.

Method

Rough Consensus

Deadline

August 2, 2024

Checklist

I, the opener of this Call for Input, have completed the following:

  • Filled in a descriptive title.
  • Filled in the "Decision" field.
  • Filled in the "If Affirmed" field.
  • Filled in the "If Rejected" field.
  • Filled in the "Method" field.
  • Filled in the "Deadline" field to be thirty days from creation.
  • Added any relevant background information (or removed the section.)
  • Published a notice in writing to the usual channels frequented by EIP Editors (likely Discord.)
  • Commented on this Call for Input, clearly stating my opinion (or abstention.)
@SamWilsn
Copy link
Collaborator Author

SamWilsn commented Jul 3, 2024

I am in favour of merging this pull request.

@abcoathup
Copy link

I would prefer Withdrawn rather than a one off status of Moved. But am not opposed to merging. (but don't have a vote)

Move means copy and delete, so ideally we would delete (completely remove) the EIP but there are already references to it (such as https://eips.ethereum.org/EIPS/eip-7600).

In future, moving an EIP to a RIP, we should issue the RIP a new number and set the EIP to Withdrawn, rather than creating another state to maintain.

@poojaranjan
Copy link
Member

IMO, EIP-7212 should be treated the same way as ERCs when EIPs GitHub repo was forked. We can use the same process for RIP-7212 because when moved it carried the number which was allocated to an EIP.

@poojaranjan
Copy link
Member

EIP-7212 was also discussed in the ACDE meeting as it is being considered for the Pectra upgrade. Adding screenshots of suggestions that surfaced.
Screenshot 2024-07-04 at 10 49 03 AM

@Dexaran Dexaran mentioned this issue Jul 5, 2024
18 tasks
@ulerdogan
Copy link

As the co-author of EIP/RIP-7212, I support merging this PR and bring 'Moved' status for the original EIP. I agree that it's a similar situation with ERCs and this necessity has been mentioned in the first RollCalls. This action will resolve recent confusion around the 7212 proposal and opens the space for L1 to directly implements an RIP or make changes by a new EIP if required.

@poojaranjan poojaranjan mentioned this issue Jul 17, 2024
10 tasks
@lightclient
Copy link

I think we should delete it

@g11tech
Copy link

g11tech commented Jul 17, 2024

+1 for delete

@SamWilsn
Copy link
Collaborator Author

Delete is fine by me.

@poojaranjan poojaranjan mentioned this issue Jul 19, 2024
3 tasks
@abcoathup
Copy link

@SamWilsn deadline is August 2 (today in Australia). 3 votes for delete.

Would be good to get this resolved (regret not renumbering the RIP).
EIP version of RIP7212 is considered for inclusion in Pectra, was discussed on ACDE 193 (https://ethereum-magicians.org/t/all-core-devs-execution-acde-193-august-1-2024/20648/2) but inclusion will be reviewed in a few months.

@SamWilsn
Copy link
Collaborator Author

SamWilsn commented Aug 2, 2024

Consensus is to delete.

@SamWilsn SamWilsn closed this as completed Aug 2, 2024
@SamWilsn
Copy link
Collaborator Author

SamWilsn commented Aug 2, 2024

ethereum/EIPs#8779

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants