Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounting for Code Deduplication #22

Open
ekpyron opened this issue Apr 19, 2023 · 1 comment
Open

Accounting for Code Deduplication #22

ekpyron opened this issue Apr 19, 2023 · 1 comment

Comments

@ekpyron
Copy link
Contributor

ekpyron commented Apr 19, 2023

[copied from matrix]
How well should the format account for code deduplication? To do this properly, basically any bytecode based debugging information would really have to be a list (by default of length 1), s.t. we can preserve all information when deduplicating - and we could even try to annotate jumps, s.t. it's possible to tell which set of information to follow across the jumps.

I'm not keen on maintaining this myself, so if you're fine with loosing information across deduplication, I'm happy, maintaining this correctly would be a mess for us - but "multi-source-maps" seemed to me to generally be a highly-requested feature...

The current format is so far (intentionally) vague about the source location specifiers, but already considers it as a list - my point, though, is that basically all information, including stack maps, etc., are potentially the result of collapsing different paths with different debugging information:
For example, the same code can act on a struct S { uint a; uint b; } and a struct VerboselyNamedStruct { uint someField; uint anotherField; }, thus technically you have more than one set of type information associated with stack items, etc. pp.

@gnidan
Copy link
Member

gnidan commented May 3, 2023

Could we do something with context-sensitive marking? Like, annotate some section of bytecode to require knowledge of type context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants