Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmony should start EthereumJ only by request #119

Open
zilm13 opened this issue Sep 6, 2018 · 0 comments
Open

Harmony should start EthereumJ only by request #119

zilm13 opened this issue Sep 6, 2018 · 0 comments

Comments

@zilm13
Copy link
Contributor

zilm13 commented Sep 6, 2018

Currently EthereumJ automatically starts with start of Harmony and this behaviour follows growing number of hacks to run Harmony as desired:

  1. Harmony config is added to ethereum.conf.res so it could be overwritten by other configs
  2. Miner is disabled on start even if it's enabled in config and started a bit later in MinerService

Fundamental improvements in EthereumJ are needed to fix it but most of them are planned and will enhance EthereumJ usage as library and improve Harmony code quality:

  1. Disable triggering of config load by static methods Usage of static methods shouldn't trigger config load ethereum/ethereumj#1012
  2. Detach EthereumJ to separate ApplicationContext in Harmony
  3. Build config for EthereumJ from code and instantiate it with this config, there should be an option in EthereumJ when it doesn't try to read config at all and starts with input config EthereumJ Config Builder ethereum/ethereumj#469
  4. Don't use beans from EthereumJ by Autowired in Harmony. Instead improve EthereumJ to provide any of this beans from some facade and we should use it that way in Harmony.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant