-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add DTBC to the master #5969
add DTBC to the master #5969
Conversation
Add Deviant Token Blockchain (DTBC)
You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review. |
changed files from Windows to Linux (so no carraige return errors) |
Just used notepad++ to change the EOL to Unix (LF). Hopefully that's it now! checked all 14 files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explorer is offline at this point. It will be working in a couple of days. We are just trying to secure the chain details on the list at this point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to remove the explorer then in order to merge - I cannot verify the explorer adheres to EIP3091
Also if the chain is not yet active add status incubating
I've removed the explorer reference, and added incubating. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is in the wrong folder with the wrong filename
Hopefully this is all correct now. I renamed and moved the file. It is now in _data/chains. It is called eip155-52027071.json |
PR merged - please consider contributing some funds to lists.eth |
Thank you for your time. The next one will be easier! Steep learning curve for sure. |
please add DTBC to the master