Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DTBC to the master #5969

Merged
merged 29 commits into from
Oct 14, 2024
Merged

add DTBC to the master #5969

merged 29 commits into from
Oct 14, 2024

Conversation

deviantmyk
Copy link
Contributor

please add DTBC to the master

Copy link

github-actions bot commented Oct 9, 2024

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

@ligi ligi mentioned this pull request Oct 9, 2024
Closed
@deviantmyk
Copy link
Contributor Author

changed files from Windows to Linux (so no carraige return errors)

@deviantmyk
Copy link
Contributor Author

deviantmyk commented Oct 9, 2024

Just used notepad++ to change the EOL to Unix (LF). Hopefully that's it now! checked all 14 files.

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explorer does not work:

Screenshot from 2024-10-09 23-10-31

@deviantmyk
Copy link
Contributor Author

deviantmyk commented Oct 10, 2024

Explorer is offline at this point. It will be working in a couple of days. We are just trying to secure the chain details on the list at this point.

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to remove the explorer then in order to merge - I cannot verify the explorer adheres to EIP3091
Also if the chain is not yet active add status incubating

@deviantmyk deviantmyk changed the title add DTBC to the master add DTBC to the master - incubating Oct 10, 2024
@deviantmyk
Copy link
Contributor Author

deviantmyk commented Oct 10, 2024

I've removed the explorer reference, and added incubating. Thanks

@deviantmyk deviantmyk requested a review from ligi October 10, 2024 21:11
Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is in the wrong folder with the wrong filename

@deviantmyk
Copy link
Contributor Author

deviantmyk commented Oct 13, 2024

Hopefully this is all correct now. I renamed and moved the file. It is now in _data/chains. It is called eip155-52027071.json
Thanks

@deviantmyk deviantmyk requested a review from ligi October 13, 2024 15:00
@deviantmyk deviantmyk changed the title add DTBC to the master - incubating add DTBC to the master Oct 14, 2024
@deviantmyk deviantmyk closed this Oct 14, 2024
@deviantmyk deviantmyk reopened this Oct 14, 2024
@ligi ligi merged commit 1a0ff5f into ethereum-lists:master Oct 14, 2024
5 checks passed
Copy link

PR merged - please consider contributing some funds to lists.eth

@deviantmyk
Copy link
Contributor Author

Thank you for your time. The next one will be easier! Steep learning curve for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants