Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sorian Chain to Chainlist #5993

Closed
wants to merge 8 commits into from

Conversation

sorian-coin
Copy link
Contributor

This pull request adds the Sorian blockchain to Chainlist, making it easier for users to connect to the network. Key details include:

Chain Name: Sorian
Chain ID: [210209
RPC URL(s): https://rpc.sorian.io
Currency Symbol: SOR
Explorer URL: https://scan.sorian.io
Please review the provided information for accuracy before merging.

Copy link

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve conflicts and do not touch kotlin/gradle files

@sorian-coin
Copy link
Contributor Author

I have solved the conflicts. Please check now. Thank you.

@sorian-coin sorian-coin requested a review from ligi October 13, 2024 17:16
@ligi
Copy link
Member

ligi commented Oct 13, 2024

do not touch gradle or kotlin files

@sorian-coin
Copy link
Contributor Author

I have solved the conflicts. Please check now. Thank you.

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are still touching files you should not touch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants