Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incubating swell mainnet 1923 #6084

Merged
merged 9 commits into from
Oct 31, 2024
Merged

Conversation

cryptoquantx
Copy link
Contributor

@cryptoquantx cryptoquantx commented Oct 28, 2024

This is to reserve chainId 1923

Copy link

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

@tilemanrenovations
Copy link

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

Copy link

@tilemanrenovations tilemanrenovations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TnMe4Rteam

@cryptoquantx cryptoquantx changed the title swell testnet 1923 swell mainnet 1923 & testnet 1924 Oct 29, 2024
@cryptoquantx
Copy link
Contributor Author

@tilemanrenovations @ligi,

RPCs and explorers are not live yet; we want to secure these chain IDs.

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add status incubating then and remove stuff that is not yet there like RPCs

@cryptoquantx cryptoquantx changed the title swell mainnet 1923 & testnet 1924 incubating swell mainnet 1923 & testnet 1924 Oct 29, 2024
@cryptoquantx
Copy link
Contributor Author

add status incubating then and remove stuff that is not yet there like RPCs

added incubating status, but RPCs are necessary fields /gradlew run won't work if I remove them.

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@cryptoquantx cryptoquantx changed the title incubating swell mainnet 1923 & testnet 1924 incubating swell mainnet 1923 Oct 31, 2024
@cryptoquantx
Copy link
Contributor Author

hey @ligi @tilemanrenovations we solved the rpc issue.

@cryptoquantx
Copy link
Contributor Author

Thank you, @ligi. The tests went through.

@ligi ligi merged commit 81a35bf into ethereum-lists:master Oct 31, 2024
5 checks passed
Copy link

PR merged - please consider contributing some funds to lists.eth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants