Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interop: Handle Empty Databases #11836

Open
axelKingsley opened this issue Sep 10, 2024 · 0 comments
Open

Interop: Handle Empty Databases #11836

axelKingsley opened this issue Sep 10, 2024 · 0 comments

Comments

@axelKingsley
Copy link
Contributor

In working on op-e2e for interop, I discovered an edge case that needs to get dealt with.

If chains don't ever produce logs, their databases stay empty. Then, when CheckBlock calls come in, the backend fails with an EOF because there's no content.

For now, I've added a clause that makes EOF an ok outcome during the backend CheckBlock, but this is also not right, as it exposes the risk of being given an intentional future block number in order to force an EOF. I think this could still be ok, because the individual Safety indexes still get checked.

The best solutions are to:

  • Gracefully/Explicitly check for situations where there's just no data recorded for a given block.
  • Add block checkpoints after every block.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant