You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// A hacky way to get the total number of elements in a JSON
// object array because Forge does not support this natively.
There is a lot of usage of jq in the monorepo forge scripts.
Also the solidity team has talked about removing abi.encodePacked in a future version of solidity, so string.concat should be preferred over string(abi.encodePacked(...))
If you are open to enabling
ffi
, it is possible to usejq
to get the length of a JSON array. It would allow for the removal of this code:superchain-ops/src/JsonTxBuilderBase.sol
Lines 24 to 25 in 2b033ba
There is a lot of usage of
jq
in the monorepo forge scripts.Also the solidity team has talked about removing
abi.encodePacked
in a future version of solidity, sostring.concat
should be preferred overstring(abi.encodePacked(...))
superchain-ops/src/JsonTxBuilderBase.sol
Line 33 in 2b033ba
The text was updated successfully, but these errors were encountered: