Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SignFromJson compatible with Safe Web UI #49

Open
zchn opened this issue Jan 25, 2024 · 3 comments
Open

Make SignFromJson compatible with Safe Web UI #49

zchn opened this issue Jan 25, 2024 · 3 comments
Assignees

Comments

@zchn
Copy link
Contributor

zchn commented Jan 25, 2024

Currently, the SignFromJson script always use Multicall3.aggregate3 to generate the transaction to be signed, example: https://dashboard.tenderly.co/k-oplabs/project/simulator/4e4efb85-acfc-4210-9a8d-55785e0b65a1

The safe web UI uses MultiSendCallOnly.multiSend to generate the transaction to be signed if there are multiple calls: https://dashboard.tenderly.co/public/safe/safe-apps/simulator/3be84dfc-96d6-4069-bae6-6f64a6da5dbf, and no multicall at all if there is a single call: https://dashboard.tenderly.co/public/safe/safe-apps/simulator/d2177dce-db8a-4999-8ac0-38d2bebe3fd4

This FR is about changing SignFromJson so it behaves just like safe web UI, so different signers can choose to use either SignFromJson or Safe Web UI and they would still see the same domain hash and message hash.

@zchn
Copy link
Contributor Author

zchn commented Jan 25, 2024

input.json

@maurelian
Copy link
Contributor

This is a great catch. I will include it in a PR which accompanies #42, prior to the ceremony.

@zchn
Copy link
Contributor Author

zchn commented Jan 25, 2024

Nice, thank you. Assigning this to you accordingly. But feel free to unassign and not work on this if this end up not blocking the extended pause upgrade and instead putting the launch date at risk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants