Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and clarify the task naming system #60

Closed
mds1 opened this issue Feb 7, 2024 · 1 comment
Closed

Update and clarify the task naming system #60

mds1 opened this issue Feb 7, 2024 · 1 comment

Comments

@mds1
Copy link
Contributor

mds1 commented Feb 7, 2024

From #55 (comment)

The PR calls this upgrade 4 but this file is called 2-*, which feels confusing. Should those match at all? Or are the 0/1/2 number prefixes for existing task folder names just communicating the order they were added to the repo for some reason?

They are meant to indicate the order in which they are executed, not map to the upgrade numbering.
There have been several upgrades which did not involve contracts, so they aren't reflected here.
We should clarify/improve on this system when we get a chance.

@mds1 mds1 mentioned this issue Feb 7, 2024
@mds1
Copy link
Contributor Author

mds1 commented Oct 2, 2024

We now have a consistent naming and numbering convention, so closing this as completed

@mds1 mds1 closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant