From fb90cf4a6eddc6535e7f1d06b3741bb3cc83332f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ula=C5=9F=20Erdo=C4=9Fan?= Date: Thu, 22 Jun 2023 15:48:07 +0300 Subject: [PATCH] Update: Update with the numbers and links --- EIPS/{eip-x.md => eip-7212.md} | 10 +++++----- assets/{eip-x => eip-7212}/benchstat_compare_test | 0 assets/{eip-x => eip-7212}/ecrecover_benchmark_test | 0 assets/{eip-x => eip-7212}/p256Verify_benchmark_test | 0 4 files changed, 5 insertions(+), 5 deletions(-) rename EIPS/{eip-x.md => eip-7212.md} (94%) rename assets/{eip-x => eip-7212}/benchstat_compare_test (100%) rename assets/{eip-x => eip-7212}/ecrecover_benchmark_test (100%) rename assets/{eip-x => eip-7212}/p256Verify_benchmark_test (100%) diff --git a/EIPS/eip-x.md b/EIPS/eip-7212.md similarity index 94% rename from EIPS/eip-x.md rename to EIPS/eip-7212.md index 1f3f24b55f8564..4dd8b758997a78 100644 --- a/EIPS/eip-x.md +++ b/EIPS/eip-7212.md @@ -1,9 +1,9 @@ --- -eip: +eip: 7212 title: Precompiled for secp256r1 Curve Support description: Proposal to add precompiled contract that allows signature verifications in the “secp256r1” elliptic curve. author: Ulaş Erdoğan (@ulerdogan), Doğan Alpaslan (@doganalpaslan) -discussions-to: https://ethereum-magicians.org/ +discussions-to: https://ethereum-magicians.org/t/eip-7212-precompiled-for-secp256r1-curve-support/14789 status: Draft type: Standards Track category: Core @@ -123,8 +123,8 @@ No backward compatibility issues found as the precompiled contract will be added Functional tests are applied for multiple cases in the [reference implementation](#Reference-Implementation) of `P256VERIFY` precompiled contract and they succeed. Benchmark tests are also applied for both `P256VERIFY` and `ECRECOVER` with some pre-calculated data and signatures in the “go-ethereum”s precompile testing structure to propose a meaningful gas cost for the “secp256r1” signature verifications by the precompiled contract implemented in the [reference implementation](#Reference-Implementation). The benchmark test results by example data in the assets can be checked: -- [P256Verify Benchmark Test Results](../assets/eip-x/p256Verify_benchmark_test) -- [Ecrecover Benchmark Test Results](../assets/eip-x/ecrecover_benchmark_test) +- [P256Verify Benchmark Test Results](../assets/eip-7212/p256Verify_benchmark_test) +- [Ecrecover Benchmark Test Results](../assets/eip-7212/ecrecover_benchmark_test) ``` # results of geth benchmark tests of @@ -168,7 +168,7 @@ geomean 33.00 7.000 ## Reference Implementation -Implementation of the `P256VERIFY` precompiled contract is applied to [go-ethereum](https://github.com/ethereum/go-ethereum/compare/master...ulerdogan:go-ethereum:ulerdogan-secp256r1) client to create a reference. Also, an “secp256r1” package has already been included in the [Besu Native](https://github.com/hyperledger/besu-native/tree/main/secp256r1) library which is used by [Besu](https://github.com/hyperledger/besu/blob/main/crypto/algorithms/src/main/java/org/hyperledger/besu/crypto/SECP256R1.java) client. +Implementation of the `P256VERIFY` precompiled contract is applied to [go-ethereum](https://github.com/ethereum/go-ethereum/pull/27540) client to create a reference. Also, an “secp256r1” package has already been included in the [Besu Native](https://github.com/hyperledger/besu-native/tree/main/secp256r1) library which is used by [Besu](https://github.com/hyperledger/besu/blob/main/crypto/algorithms/src/main/java/org/hyperledger/besu/crypto/SECP256R1.java) client. ## Security Considerations diff --git a/assets/eip-x/benchstat_compare_test b/assets/eip-7212/benchstat_compare_test similarity index 100% rename from assets/eip-x/benchstat_compare_test rename to assets/eip-7212/benchstat_compare_test diff --git a/assets/eip-x/ecrecover_benchmark_test b/assets/eip-7212/ecrecover_benchmark_test similarity index 100% rename from assets/eip-x/ecrecover_benchmark_test rename to assets/eip-7212/ecrecover_benchmark_test diff --git a/assets/eip-x/p256Verify_benchmark_test b/assets/eip-7212/p256Verify_benchmark_test similarity index 100% rename from assets/eip-x/p256Verify_benchmark_test rename to assets/eip-7212/p256Verify_benchmark_test