Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP: Tokenized Vaults with Lock-in Period #6229

Closed
wants to merge 8 commits into from
Closed

Add EIP: Tokenized Vaults with Lock-in Period #6229

wants to merge 8 commits into from

Conversation

Ankarrr
Copy link

@Ankarrr Ankarrr commented Dec 28, 2022

This draft EIP is an extension of the EIP-4626 Tokenized Vaults that provides functions to support the lock-in period.

I used the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

@github-actions github-actions bot added c-new Creates a brand new proposal e-number Waiting on EIP Number assignment s-draft This EIP is a Draft labels Dec 28, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Dec 28, 2022 •
edited
Loading

File EIPS/eip-6229.md

Requires 1 more reviewers from @axic, @SamWilsn, @xinbenlv

@Ankarrr
Copy link
Author

Ankarrr commented Dec 28, 2022

Should I rename it to EIP-6229?

@Ankarrr Ankarrr dismissed a stale review via 171dbcb December 29, 2022 02:53
@github-actions github-actions bot removed the e-number Waiting on EIP Number assignment label Dec 29, 2022
@Ankarrr Ankarrr changed the title Add draft: Tokenized Vaults with Lock-in Period EIP 6229: Tokenized Vaults with Lock-in Period Dec 29, 2022
@Ankarrr Ankarrr changed the title EIP 6229: Tokenized Vaults with Lock-in Period EIP-6229: Tokenized Vaults with Lock-in Period Dec 29, 2022
@Ankarrr Ankarrr changed the title EIP-6229: Tokenized Vaults with Lock-in Period EIP Draft: Tokenized Vaults with Lock-in Period Jan 2, 2023
@Ankarrr Ankarrr force-pushed the eip-draft-tokenized-vault-with-lock-in-period branch from 171dbcb to 0cb8567 Compare January 2, 2023 06:17
@github-actions github-actions bot added e-number Waiting on EIP Number assignment t-erc labels Jan 2, 2023
@Ankarrr Ankarrr force-pushed the eip-draft-tokenized-vault-with-lock-in-period branch from 60dda94 to 1426860 Compare January 2, 2023 06:27
@Ankarrr Ankarrr force-pushed the eip-draft-tokenized-vault-with-lock-in-period branch from 1426860 to 1e0d3b4 Compare January 2, 2023 06:29
@github-actions github-actions bot removed the e-number Waiting on EIP Number assignment label Jan 16, 2023
@Ankarrr Ankarrr changed the title EIP Draft: Tokenized Vaults with Lock-in Period EIP-6229: Tokenized Vaults with Lock-in Period Jan 16, 2023
@Pandapip1 Pandapip1 changed the title EIP-6229: Tokenized Vaults with Lock-in Period Add EIP-6229: Tokenized Vaults with Lock-in Period Jan 25, 2023
Pandapip1
Pandapip1 suggested changes Jan 25, 2023
View reviewed changes
EIPS/eip-6229.md Show resolved Hide resolved
EIPS/eip-6229.md Outdated Show resolved Hide resolved
EIPS/eip-6229.md Outdated Show resolved Hide resolved
EIPS/eip-6229.md Outdated Show resolved Hide resolved
EIPS/eip-6229.md Outdated Show resolved Hide resolved
EIPS/eip-6229.md Outdated Show resolved Hide resolved
EIPS/eip-6229.md Outdated Show resolved Hide resolved
EIPS/eip-6229.md Outdated Show resolved Hide resolved
EIPS/eip-6229.md Outdated Show resolved Hide resolved
EIPS/eip-6229.md Outdated Show resolved Hide resolved
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Apr 27, 2023
@github-actions github-actions bot removed the w-stale Waiting on activity label May 15, 2023
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label May 30, 2023
@github-actions
Copy link

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this Jul 11, 2023
Ankarrr
Ankarrr commented Apr 30, 2024
View reviewed changes
Copy link
Author

@Ankarrr Ankarrr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Pandapip1, thank you very much for your review. Sorry for the long delay. I have made adjustments based on your feedback. I find that I am unable to reopen and push commit to this PR. Could you advise on how I should proceed?

EIPS/eip-6229.md Outdated Show resolved Hide resolved
EIPS/eip-6229.md Outdated Show resolved Hide resolved
EIPS/eip-6229.md Show resolved Hide resolved
EIPS/eip-6229.md Outdated Show resolved Hide resolved
EIPS/eip-6229.md Outdated Show resolved Hide resolved
EIPS/eip-6229.md Outdated Show resolved Hide resolved
EIPS/eip-6229.md Outdated Show resolved Hide resolved
EIPS/eip-6229.md Outdated Show resolved Hide resolved
EIPS/eip-6229.md Outdated Show resolved Hide resolved
EIPS/eip-6229.md Outdated Show resolved Hide resolved
@Pandapip1
Copy link
Member

I'm afraid that I resigned as an editor a couple of months ago. I'll request a current editor.

@Pandapip1 Pandapip1 reopened this Apr 30, 2024
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Apr 30, 2024
@eth-bot eth-bot changed the title Add EIP-6229: Tokenized Vaults with Lock-in Period Add EIP: Tokenized Vaults with Lock-in Period Apr 30, 2024
@Pandapip1
Copy link
Member

This should be migrated to https://github.com/ethereum/ERCs

@Pandapip1 Pandapip1 closed this Apr 30, 2024
@github-actions GitHub Actions
Copy link

The commit 0952acb (as a parent of 36da284) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 30, 2024
@Ankarrr
Copy link
Author

Ankarrr commented May 2, 2024

@Pandapip1 ok, I'll migrate it to ERC repo

@Ankarrr Ankarrr mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pandapip1 Pandapip1 Pandapip1 requested changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Assignees
No one assigned
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-erc w-ci Waiting on CI to pass w-stale Waiting on activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ankarrr @eth-bot @Pandapip1