Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-1: EIP pain relief #7230

Closed
wants to merge 49 commits into from
Closed

Conversation

gcolvin
Copy link
Contributor

@gcolvin gcolvin commented Jun 25, 2023

This draft PR is very much a work in progress. So far it tries to alleviate some known pain points in the EIP process. These include

  • getting a Draft into the repo in the first place
  • editing a document while complying with changing rules
  • referencing relevant resources that aren't specifically allowed
  • ensuring that all referenced resources remain accessible
  • assuring that the many Drafts we edit are technically sound and of high quality
  • integrating the EIP process with the Reference Implementations and Core Devs workflows.

Note: This is independent of whether to split the repo.

Note: The intent is that once an EIP is a Draft the Core Developers will have full control of their workflow until the EIP reaches FInal. The stages of their workflow are not defined by the Editors. The Editors should never be in the position of blocking an upgrade.

To begin with the last:

The Editors and the Developers are fairly independent organizations, with the Editors trying provide the services needed to publish a consistent series of high-quality EIPs. We had envisioned (years back) that most proposals would arrive via independent Working Groups. For the most part working groups didn't happen except, de-facto, the Core Developers.

We propose to clarify the status of Working Groups, and to treat the Core Developers as an independent Working Group, responsible for the specification of Core EIPs and in control of their own workflow.

The Editorial stages for WG EIPs are reduced to three: Draft, Final, or Withdrawn. Anything in between is part of the WG workflow, and should be tracked as such. The formatting and notational requirements for a Specification, its relationship to other specifications, none of these are editorial concerns. They belong to the Working Group.

The Editors retain responsibility for publishing a high-quality series of standards. To that end we maintain the overall requirements for spelling, style, headers, citations, overall format (Abstract ... References ...) and the like. (Some core developers are already serving as editors, so we have a start on coordination.)

For the rest:

We propose to relax the enforcement of EIPW rules for Drafts, enforcing tighter rules only on changes of Status. This should reduce a lot of the friction in the workflow.

Our policy of accepting only a limited range of URLs has caused much pain. We propose to relax that policy. We allow wide editorial and working group discretion on the careful use of external resources, in line with IETF practice. All references must include full citations with authors, title, and publication information, including available DOIs. This helps to ensure that over time external resources can almost always be found somewhere.

We add a few optional headers for use by Working Groups to track their workflow.

We propose to introduce the role of Technical Peers -- volunteers with relevant expertise who can help Authors review their work at the Idea stage. Editors may ask for them when a proposal needs more technical review than the Editors are able to give it. This should help to reduce the strain on the Editor's and increase the quality and general usefulness of proposals, especially ERCs.

EDITED 2023-08-01

@gcolvin gcolvin requested a review from eth-bot as a code owner June 25, 2023 05:54
@gcolvin gcolvin marked this pull request as draft June 25, 2023 05:55
@eth-bot
Copy link
Collaborator

eth-bot commented Jun 25, 2023

File EIPS/eip-1.md

Requires 2 more reviewers from @axic, @lightclient, @Pandapip1, @SamWilsn

@eth-bot eth-bot changed the title pain relief Update EIP-1: pain relief Jun 25, 2023
@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Jun 25, 2023
@github-actions github-actions bot added c-update Modifies an existing proposal w-ci Waiting on CI to pass labels Jun 25, 2023
@gcolvin gcolvin changed the title Update EIP-1: pain relief EIP pain relief Jun 25, 2023
@github-actions github-actions bot removed the c-update Modifies an existing proposal label Jun 25, 2023
@eth-bot eth-bot changed the title EIP pain relief Update EIP-1: EIP pain relief Jun 25, 2023
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Jun 25, 2023
@github-actions github-actions bot added c-update Modifies an existing proposal and removed w-ci Waiting on CI to pass labels Jun 25, 2023
EIPS/eip-1.md Outdated
A PR moving an EIP from Last Call to Final SHOULD contain no changes other than the status update. Any content or editorial proposed change SHOULD be separate from this status-updating PR and committed prior to it.
- **Idea** - An idea that is pre-draft. This is not tracked within the EIP Repository.
- **Draft** - The first formally tracked stage of an EIP in development. An EIP is merged by an EIP Editor into the EIP repository when it meets some initial requirements: It should be technically sound, the Title and Preamble must be correct, and all included Sections should be readable. Problems with language like spelling, grammar, markup, etc. are only considered warnings.
- **Review** - An EIP Author marks an EIP as ready for and requesting Peer Review. An Editor will merge the EIP when it meets all EIP requirements: it should be a technically sound, complete specification, properly formatted, with correct language, markup and external references.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording here feels a bit off.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Just a sketch to get discussion started.

EIPS/eip-1.md Outdated Show resolved Hide resolved
EIPS/eip-1.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jun 26, 2023
EIPS/eip-1.md Outdated Show resolved Hide resolved
EIPS/eip-1.md Outdated Show resolved Hide resolved
EIPS/eip-1.md Outdated Show resolved Hide resolved
EIPS/eip-1.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jul 21, 2023
@github-actions github-actions bot added c-update Modifies an existing proposal w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Jul 21, 2023
@gcolvin
Copy link
Contributor Author

gcolvin commented Jul 21, 2023

For me they do appear to have committed just fine
I don't understand at all then. But I just went to this PR on the Web and used Github's own editor and cleaned up all the old-style Optional annotations I still found there. (And then had to undo the damage of an ill-advised search-and-replace.)

Comment on lines +493 to +494
<!--- markdownlint-capture --->
<!--- markdownlint-disable code-block-style --->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the extra dash?

Copy link
Contributor Author

@gcolvin gcolvin Jul 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dashes are from an ill-advised global search-and-replace. I've fixed them, but the bot, in it's infinite wisdom, suddenly decided that the DOI example -- which has been there since 2022-- must now be fixed before I can check in my changes. And since I am a second-class editor I can't override it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following is the error that just popped up. I cannot find any difference to explain why it suddenly complained.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a sentence with a footnote.[^1]

[^1]:
    ```csl-json
    {
 Check failure on line 500 in EIPS/eip-1.md
GitHub
Actions
/ Markdown Linter

Code block style [Expected: fenced; Actual: indented]

EIPS/eip-1.md:500 MD046/code-block-style Code block style [Expected: fenced; Actual: indented]
      "type": "article",
      "id": 1,
      "author": [

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always complained about this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the markdownlint bot isn't a required check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks. It does seem to be generating bad output at the end of the document, and I don't know how I broke it.

@@ -4,6 +4,7 @@ title: EIP Purpose and Guidelines
status: Living
type: Meta
author: Martin Becze <[email protected]>, Hudson Jameson <[email protected]>, et al.
discussions-to: https://ethereum-magicians.org/t/update-eip-1-eip-pain-relief-7230/15082
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be here?

EIPS/eip-1.md Outdated Show resolved Hide resolved
EIPS/eip-1.md Outdated Show resolved Hide resolved
EIPS/eip-1.md Outdated Show resolved Hide resolved
EIPS/eip-1.md Outdated Show resolved Hide resolved
@github-actions
Copy link

The commit 3675990 (as a parent of d6d3513) contains errors.
Please inspect the Run Summary for details.


If the EIP isn't ready, the editor will send it back to the author for revision, with specific instructions.
If the EIP isn't ready, the editor will send it back to the author with instructions for revision and possibly a request for review by Technical Peers.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If the EIP isn't ready, the editor will send it back to the author with instructions for revision and possibly a request for review by Technical Peers.
If the EIP isn't ready, the editor will send it back to the author with instructions for revision and possibly a request for review by Technical Peers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to the suggestion. Would it make sense to get more specific and recommend a particular WG that they get review from as well?

Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Nov 15, 2023
@github-actions github-actions bot removed the w-stale Waiting on activity label Nov 29, 2023
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added w-stale Waiting on activity and removed w-stale Waiting on activity labels Dec 13, 2023
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Dec 29, 2023
Copy link

github-actions bot commented Feb 9, 2024

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus t-process w-ci Waiting on CI to pass w-stale Waiting on activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants