Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-7144: Move to Review #7239

Merged
merged 14 commits into from
Aug 8, 2023
Merged

Update EIP-7144: Move to Review #7239

merged 14 commits into from
Aug 8, 2023

Conversation

eduardfina
Copy link
Contributor

Move to Review

@eduardfina eduardfina requested a review from eth-bot as a code owner June 27, 2023 11:59
@github-actions github-actions bot added c-status Changes a proposal's status s-review This EIP is in Review t-erc labels Jun 27, 2023
@poojaranjan poojaranjan mentioned this pull request Jul 11, 2023
Closed
15 tasks
SamWilsn
SamWilsn requested changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code within the EIP itself must be licensed as CC0. You must either: change it to CC0-1.0 or move it to the assets directory and link to it from the EIP.

@eth-bot
Copy link
Collaborator

eth-bot commented Jul 11, 2023 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot added the e-review Waiting on editor to review label Jul 11, 2023
@eduardfina
Copy link
Contributor Author

Code license changed to CC0-1.0

@eduardfina eduardfina requested a review from SamWilsn July 13, 2023 13:57
@poojaranjan poojaranjan mentioned this pull request Aug 8, 2023
Closed
21 tasks
@eth-bot eth-bot enabled auto-merge (squash) August 8, 2023 14:58
eth-bot
eth-bot approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 3d36176 into ethereum:master Aug 8, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWilsn SamWilsn SamWilsn approved these changes

@eth-bot eth-bot eth-bot approved these changes

Assignees
No one assigned
Labels
c-status Changes a proposal's status e-review Waiting on editor to review s-review This EIP is in Review t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eduardfina @eth-bot @SamWilsn @eduardJobchain