Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP: EVM Object Format (EOFv1) Meta #8448

Merged
merged 5 commits into from
May 8, 2024
Merged

Add EIP: EVM Object Format (EOFv1) Meta #8448

merged 5 commits into from
May 8, 2024

Conversation

pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Apr 17, 2024 •
edited
Loading

Just a list of EOF EIPs.

@pdobacz pdobacz requested a review from eth-bot as a code owner April 17, 2024 06:56
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-meta labels Apr 17, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 17, 2024 •
edited
Loading

🛑 Auto merge failed. Please see logs for more details, and report this issue at the eip-review-bot repository.

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Apr 17, 2024
@pdobacz pdobacz changed the title Add EIP: Ethereum Object Format (EOF) Meta Add EIP: EVM Object Format (EOF) Meta Apr 17, 2024
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 17, 2024
@pdobacz pdobacz mentioned this pull request Apr 17, 2024
Closed
19 tasks
@github-actions GitHub Actions
Copy link

The commit 29ed141 (as a parent of c65261d) contains errors.
Please inspect the Run Summary for details.

abcoathup
abcoathup reviewed Apr 18, 2024
View reviewed changes
EIPS/eip-eof-meta.md Outdated Show resolved Hide resolved
abcoathup
abcoathup reviewed Apr 18, 2024
View reviewed changes
EIPS/eip-eof-meta.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Apr 18, 2024
@jochem-brouwer
Copy link
Member

jochem-brouwer commented May 1, 2024 •
edited
Loading

These URLs do not work, could you append .md to the URLs?

g11tech
g11tech reviewed May 1, 2024
View reviewed changes
EIPS/eip-7692.md Outdated Show resolved Hide resolved
@gumb0
Copy link
Member

gumb0 commented May 2, 2024

As #8498 is merged now, please also add EIP-7698

@gumb0
Copy link
Member

gumb0 commented May 6, 2024 •
edited
Loading

@g11tech @abcoathup Please take a look, comments were addressed.

g11tech
g11tech previously approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@g11tech g11tech closed this May 8, 2024
@g11tech g11tech reopened this May 8, 2024
SamWilsn
SamWilsn requested changes May 8, 2024
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of these kinds of EIPs. They will get out of date once they go final.

Unless the intent is to say that once EOF is included, this list will never change and there will never be another EOF proposal? I'd be okay with that.

@pdobacz
Copy link
Contributor Author

pdobacz commented May 8, 2024

I'm not a fan of these kinds of EIPs. They will get out of date once they go final.

Unless the intent is to say that once EOF is included, this list will never change and there will never be another EOF proposal? I'd be okay with that.

@SamWilsn

It has been produced in response to a direct request from ACDE. However, there is a mental shortcut you're pointing out here - it lists EIPs for EOF v1, as CFId for Prague. We can somehow make this clear in the text, I'm not exactly sure yet how. Currently it only names it "Mega EOF" in the description, which might not be clear to everyone.

@eth-bot eth-bot changed the title Add EIP: EVM Object Format (EOF) Meta Add EIP: EVM Object Format (EOFv1) Meta May 8, 2024
@pdobacz
Copy link
Contributor Author

pdobacz commented May 8, 2024

Follow-up: @SamWilsn See if 47e0e06 would fix the issue

@pdobacz pdobacz requested a review from SamWilsn May 8, 2024 16:52
@SamWilsn SamWilsn merged commit ceb5d55 into ethereum:master May 8, 2024
15 of 17 checks passed
@pdobacz pdobacz deleted the eof-meta-eip branch May 9, 2024 07:04
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
@pdobacz @GAEAlimited
Add EIP: EVM Object Format (EOFv1) Meta (ethereum#8448)
b29f1c1 
* Add EIP: EVM Object Format (EOF) Meta

* Assigned EIP number

* Fix links

* Fixup - missed requires entry for 7698

* Specify EOFv1 is meant
blacksnow2 pushed a commit to blacksnow2/EIPs that referenced this pull request Jul 21, 2024
@pdobacz @blacksnow2
Add EIP: EVM Object Format (EOFv1) Meta (ethereum#8448)
88f3bc5 
* Add EIP: EVM Object Format (EOF) Meta

* Assigned EIP number

* Fix links

* Fixup - missed requires entry for 7698

* Specify EOFv1 is meant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcoathup abcoathup abcoathup left review comments

@zaidusmanali zaidusmanali zaidusmanali approved these changes

@SamWilsn SamWilsn SamWilsn approved these changes

@gumb0 gumb0 gumb0 approved these changes

@chfast chfast chfast approved these changes

@g11tech g11tech g11tech left review comments

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Assignees
No one assigned
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@pdobacz @eth-bot @jochem-brouwer @gumb0 @chfast @abcoathup @SamWilsn @g11tech @zaidusmanali