Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Add wallet_signIntendedValidatorData method #8774

Merged
merged 8 commits into from
Aug 20, 2024

Conversation

YamenMerhi
Copy link
Contributor

@YamenMerhi YamenMerhi commented Jul 30, 2024

  • Add wallet_signIntendedValidatorData JSON-RPC method

to discuss and to know more with non standardized sections here: PatronumLabs/wallet_signIntendedValidatorData

@YamenMerhi YamenMerhi requested a review from eth-bot as a code owner July 30, 2024 18:58
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-interface labels Jul 30, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Jul 30, 2024

✅ All reviewers have approved.

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Jul 30, 2024
@eth-bot eth-bot changed the title Add wallet_signIntendedValidatorData JSON-RPC method Add EIP: Add wallet_signIntendedValidatorData JSON-RPC method Jul 30, 2024
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jul 30, 2024
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jul 30, 2024
@eth-bot eth-bot changed the title Add EIP: Add wallet_signIntendedValidatorData JSON-RPC method Add EIP: Add wallet_signIntendedValidatorData JSON-RPC Jul 30, 2024
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jul 30, 2024
@eth-bot eth-bot changed the title Add EIP: Add wallet_signIntendedValidatorData JSON-RPC Add EIP: Add wallet_signIntendedValidatorData method Jul 30, 2024
Copy link

The commit b70087d (as a parent of adbf77d) contains errors.
Please inspect the Run Summary for details.

EIPS/eip-x.md Outdated Show resolved Hide resolved
EIPS/eip-x.md Outdated Show resolved Hide resolved
EIPS/eip-x.md Outdated Show resolved Hide resolved
@YamenMerhi YamenMerhi changed the title Add EIP: Add wallet_signIntendedValidatorData method Add EIP-7749: Add wallet_signIntendedValidatorData method Aug 2, 2024
@eth-bot eth-bot changed the title Add EIP-7749: Add wallet_signIntendedValidatorData method Add EIP: Add wallet_signIntendedValidatorData method Aug 2, 2024
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Aug 2, 2024
@YamenMerhi
Copy link
Contributor Author

Ping


`DATA` - Signature.

#### Example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example request/response probably belongs in the Test Cases section. Ideally, we'd like to see a JSON Schema in the specification section describing the endpoint.

@eth-bot eth-bot enabled auto-merge (squash) August 20, 2024 14:56
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 9d7dbb7 into ethereum:master Aug 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants