-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-3155: Move to Draft #8798
Merged
Merged
+110
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move to last call and some minor edits. Normative: move memSize position Normative: Remove implementation links (per current linking policy) Non-normative: update sample test case Non-normative: formatting and minor verbiage edits
✅ All reviewers have approved. |
eth-bot
changed the title
EIP-3155: Move to Last Call
Update EIP-3155: Move to Last Call
Aug 13, 2024
The commit f61a73e (as a parent of ae6fbfc) contains errors. |
Put it on the ~~blacklist~~ denylist.
MariusVanDerWijden
approved these changes
Aug 13, 2024
Normative: Simple Subroutines was removed (EIP-2315) - remove unused elements.
eth-bot
changed the title
Update EIP-3155: Move to Last Call
Update EIP-3155: Move to Draft
Aug 15, 2024
SamWilsn
approved these changes
Aug 15, 2024
eth-bot
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
Allzz77123
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a-review
Waiting on author to review
c-status
Changes a proposal's status
s-draft
This EIP is a Draft
t-interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move EIP-3155 to last call and some minor edits.
Normative: move memSize position
Normative: Remove implementation links (per current linking policy)
Non-normative: update sample test case
Non-normative: formatting and minor verbiage edits