Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-3155: Move to Draft #8798

Merged
merged 5 commits into from
Aug 15, 2024
Merged

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Aug 13, 2024

Move EIP-3155 to last call and some minor edits.

Normative: move memSize position
Normative: Remove implementation links (per current linking policy)
Non-normative: update sample test case
Non-normative: formatting and minor verbiage edits

Move to last call and some minor edits.

Normative: move memSize position
Normative: Remove implementation links (per current linking policy)
Non-normative: update sample test case
Non-normative: formatting and minor verbiage edits
@shemnon shemnon requested a review from eth-bot as a code owner August 13, 2024 17:06
@github-actions github-actions bot added c-status Changes a proposal's status t-interface labels Aug 13, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 13, 2024

✅ All reviewers have approved.

@eth-bot eth-bot added the a-review Waiting on author to review label Aug 13, 2024
@eth-bot eth-bot changed the title EIP-3155: Move to Last Call Update EIP-3155: Move to Last Call Aug 13, 2024
Copy link

The commit f61a73e (as a parent of ae6fbfc) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Aug 13, 2024
Put it on the ~~blacklist~~ denylist.
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Aug 13, 2024
Normative: Simple Subroutines was removed (EIP-2315) - remove unused elements.
@github-actions github-actions bot added the s-draft This EIP is a Draft label Aug 15, 2024
@eth-bot eth-bot changed the title Update EIP-3155: Move to Last Call Update EIP-3155: Move to Draft Aug 15, 2024
@eth-bot eth-bot enabled auto-merge (squash) August 15, 2024 17:05
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit b5c7a15 into ethereum:master Aug 15, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-status Changes a proposal's status s-draft This EIP is a Draft t-interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants