Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-7542: modify eip-7542 wrong words to correct #8258

Closed
wants to merge 2 commits into from
Closed

Update EIP-7542: modify eip-7542 wrong words to correct #8258

wants to merge 2 commits into from
+4 −4

Conversation

t0m1sacat
Copy link
Contributor

ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-networking labels Feb 24, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 24, 2024 •
edited
Loading

File EIPS/eip-7542.md

Requires 1 more reviewers from @smartprogrammer93

File _config.yml

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @xinbenlv

@eth-bot eth-bot added a-review Waiting on author to review e-consensus Waiting on editor consensus labels Feb 24, 2024
@eth-bot eth-bot changed the title modify eip-7542 wrong words to correct Update EIP-7542: modify eip-7542 wrong words to correct Feb 24, 2024
gaudren
gaudren reviewed Feb 28, 2024
View reviewed changes
Copy link

@gaudren gaudren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Should "the" be "then" in the Description section?

@github-actions GitHub Actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label May 10, 2024
@smartprogrammer93
Copy link
Contributor

these spelling fixes are already in the EIP. you can close this PR. thank you

@github-actions github-actions bot removed the w-stale Waiting on activity label Jun 12, 2024
@github-actions GitHub Actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Jun 27, 2024
@Parasos
Copy link

Parasos commented Jun 27, 2024 via email

@github-actions github-actions bot removed the w-stale Waiting on activity label Jun 28, 2024
@github-actions GitHub Actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Jul 12, 2024
@poojaranjan poojaranjan mentioned this pull request Oct 16, 2024
Open
16 tasks
@SamWilsn SamWilsn closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaudren gaudren gaudren left review comments

@g11tech g11tech g11tech approved these changes

@SamWilsn SamWilsn SamWilsn approved these changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Assignees
No one assigned
Labels
a-review Waiting on author to review c-update Modifies an existing proposal e-consensus Waiting on editor consensus s-draft This EIP is a Draft t-networking w-stale Waiting on activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@t0m1sacat @eth-bot @smartprogrammer93 @Parasos @SamWilsn @g11tech @gaudren