From 4741939fba4af2154a8bc13922e5400d66981f12 Mon Sep 17 00:00:00 2001 From: george Date: Tue, 23 Jul 2024 02:52:02 +0800 Subject: [PATCH 1/2] Update EIP-7251: fix typos and correct get_excess_consolidation_requests() get_excess_consolidation_requests() function has no input. --- EIPS/eip-7251.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/EIPS/eip-7251.md b/EIPS/eip-7251.md index aaf479a9b76804..0dae971efd3ced 100644 --- a/EIPS/eip-7251.md +++ b/EIPS/eip-7251.md @@ -29,11 +29,11 @@ With the security model of the protocol no longer dependent on a low value for ` | Name | Value | Comment | | - | - | - | | `CONSOLIDATION_REQUEST_TYPE` | `0x02` | The [EIP-7685](./eip-7685.md) type prefix for consolidation request | -| `CONSOLIDATION_REQUEST_PREDEPLOY_ADDRESS` | `0x` | Where to call and store relevant details about consolidation requests mechanism | +| `CONSOLIDATION_REQUEST_PREDEPLOY_ADDRESS` | `0x` | Where to call and store relevant details about consolidation request mechanism | | `SYSTEM_ADDRESS` | `0xfffffffffffffffffffffffffffffffffffffffe` | Address used to invoke system operation on contract | | `EXCESS_CONSOLIDATION_REQUESTS_STORAGE_SLOT` | `0` | | | `CONSOLIDATION_REQUEST_COUNT_STORAGE_SLOT` | `1` | | -| `CONSOLIDATION_REQUEST_QUEUE_HEAD_STORAGE_SLOT` | `2` | Pointer to head of the consolidation request message queue | +| `CONSOLIDATION_REQUEST_QUEUE_HEAD_STORAGE_SLOT` | `2` | Pointer to the head of the consolidation request message queue | | `CONSOLIDATION_REQUEST_QUEUE_TAIL_STORAGE_SLOT` | `3` | Pointer to the tail of the consolidation request message queue | | `CONSOLIDATION_REQUEST_QUEUE_STORAGE_OFFSET` | `4` | The start memory slot of the in-state consolidation request message queue | | `MAX_CONSOLIDATION_REQUESTS_PER_BLOCK` | `1` | Maximum number of consolidation requests that can be dequeued into a block | @@ -72,7 +72,7 @@ encoded = CONSOLIDATION_REQUEST_TYPE ++ rlp([source_address, source_pubkey, targ The contract has three different code paths, which can be summarized at a high level as follows: 1. Add consolidation request - requires a `96` byte input, concatenated public keys of the source and the target validators. -2. Excess consolidation requests getter - if the input length is zero, return the current excess consolidation requests count. +2. Excess consolidation requests getter - return the current excess consolidation requests count. 3. System process - if called by system address, pop off the consolidation requests for the current block from the queue. ##### Add Consolidation Request From 04279a8d58779660cecae717e2b84219786ce2a0 Mon Sep 17 00:00:00 2001 From: george Date: Wed, 24 Jul 2024 13:38:59 +0800 Subject: [PATCH 2/2] Update eip-7251.md follow mkalinin's suggestion to keep the input length condition in the descryption of the getter. --- EIPS/eip-7251.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/EIPS/eip-7251.md b/EIPS/eip-7251.md index 0dae971efd3ced..aaa4b0b88dda79 100644 --- a/EIPS/eip-7251.md +++ b/EIPS/eip-7251.md @@ -72,7 +72,7 @@ encoded = CONSOLIDATION_REQUEST_TYPE ++ rlp([source_address, source_pubkey, targ The contract has three different code paths, which can be summarized at a high level as follows: 1. Add consolidation request - requires a `96` byte input, concatenated public keys of the source and the target validators. -2. Excess consolidation requests getter - return the current excess consolidation requests count. +2. Excess consolidation requests getter - if the input length is zero, return the current excess consolidation requests count. 3. System process - if called by system address, pop off the consolidation requests for the current block from the queue. ##### Add Consolidation Request