Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validators gain/lose value during their 2 dynasty waiting period #60

Open
djrtwo opened this issue Mar 26, 2018 · 2 comments
Open

Validators gain/lose value during their 2 dynasty waiting period #60

djrtwo opened this issue Mar 26, 2018 · 2 comments
Labels

Comments

@djrtwo
Copy link
Contributor

djrtwo commented Mar 26, 2018

Issue

@yzhang90 pointed out that because a validator's deposit is scaled at current_epoch when they make a deposit but that they don't get to participate in consensus until 2 dynasties from then (at least two epochs), the validator has a period of time in which they gain/lose ether but cannot participate in consensus.

Proposed Implementation [UNFINISHED]

The below proposal is incomplete
Instead of storing a scaled ether deposit when the validator logs in, just store the raw ether, scaling by both the start_dynasty and end_dynasty scale factor when relevant (withdrawal`).

This works for the individual deposits but does not solve the issue for dynasty_wei_delta.

@djrtwo
Copy link
Contributor Author

djrtwo commented Mar 26, 2018

@karlfloersch @vbuterin @ChihChengLiang Requesting your comments on the above issue.

@ChihChengLiang
Copy link
Contributor

Just thinking out loud. So during these 2 dynasties, the validator loses deposit due to not voting. but should be able to earn back after few more dynasties.
If we want to patch it, should we have a temporary deposit that becomes real deposit after start_dynasty and is not getting rescaled before start_dynasty?

@djrtwo djrtwo self-assigned this Mar 26, 2018
@djrtwo djrtwo added bug and removed bug labels Mar 26, 2018
@djrtwo djrtwo removed their assignment Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants