Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic in markdown-json-cite with non-ASCII input #100

Open
SamWilsn opened this issue Jul 4, 2024 · 3 comments
Open

Panic in markdown-json-cite with non-ASCII input #100

SamWilsn opened this issue Jul 4, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@SamWilsn
Copy link
Contributor

SamWilsn commented Jul 4, 2024

The following (also attached) causes a panic:

---
eip: 3
---

Some text somewhere that needs a citation. [^1]

[^1]:
    ```csl-json
    {
      "author": [
        {
          "family": "Mazières"
        }
      ]
    }
    ```

The panic:

$ eipw --config ../config/eipw.toml eip-3074.md
thread 'main' panicked at /home/sam/.cargo/registry/src/index.crates.io-6f17d22bba15001f/annotate-snippets-0.9.2/src/display_list/from_snippet.rs:275:9:
SourceAnnotation range `(0, 99)` is bigger than source length `98`
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
@SamWilsn SamWilsn added the bug Something isn't working label Aug 14, 2024
@0xshikhar
Copy link

Hey @SamWilsn , would like to work on this task - can you assign me that. Could you clarify the remaining tasks for this issue? Any additional context would be appreciated. Thanks!

@SamWilsn
Copy link
Contributor Author

This is pretty much it. Take the attached input, and fix the panic. Any fixes would be very appreciated!

@0xshikhar
Copy link

got it. will like to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants