Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error if referenced EIPs are not included in requires preamble header #29

Open
Pandapip1 opened this issue Jul 31, 2022 · 3 comments
Open
Labels
in discussion Feature is still in discussion and should not be implemented

Comments

@Pandapip1
Copy link
Member

From ethereum/EIP-Bot#69

@SamWilsn SamWilsn added the in discussion Feature is still in discussion and should not be implemented label Aug 18, 2022
@Pandapip1
Copy link
Member Author

I believe this is already added.

@SamWilsn SamWilsn reopened this Feb 27, 2023
@SamWilsn
Copy link
Contributor

We never decided if we wanted to implement this. I'm happy to close if you've changed your mind though!

I still believe that a reference does not necessarily imply a "requires" dependency, though maybe we could do a warn-level lint to the effect of:

warning[markdown-requires]: `EIP-1234` mentioned without being included in `requires` preamble field
 --> input.md:50:8
   |
50 | banana [EIP-1234](./eip-1234.md)
   |        ^^^^^^^^^^^^^^^^^^^^^^^^^ mentioned here
   |
  = help: Unless necessary for understanding or implementation, mentioning another proposal can slow standardization.

@Pandapip1
Copy link
Member Author

Oh, I thought you mean referenced in specification/title/description. Those are already implemented.

I would appreciate a warning, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in discussion Feature is still in discussion and should not be implemented
Projects
None yet
Development

No branches or pull requests

2 participants