Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discussions-to links must not contain unescaped special characters #59

Open
Pandapip1 opened this issue Dec 21, 2022 · 2 comments
Open

discussions-to links must not contain unescaped special characters #59

Pandapip1 opened this issue Dec 21, 2022 · 2 comments

Comments

@Pandapip1
Copy link
Member

Pandapip1 commented Dec 21, 2022 •
edited
Loading

See ethereum/EIPs#6172 (comment)
@SamWilsn
Copy link
Contributor

Ha, this author is really doing some good QA 🤣

IMO, eipw shouldn't check whether the discussion-to link exists, just that it's on Ethereum Magicians. The link proofer should be able to tell if the thread has been created, right?

Or did the comma get parsed as some kind of array separator, and it made two separate links? In that case, yeah, eipw should be more strict.

@Pandapip1
Copy link
Member Author

Or did the comma get parsed as some kind of array separator, and it made two separate links? In that case, yeah, eipw should be more strict.

All special characters, unless escaped (e.g. , being %2C), should be assumed to be invalid.

@Pandapip1 Pandapip1 changed the title discussions-to link checker isn't aggressive enough discussions-to links must not contain unescaped special characters Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Pandapip1 @SamWilsn