Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discussions-to grandfathering #86

Open
fulldecent opened this issue Sep 1, 2023 · 2 comments
Open

discussions-to grandfathering #86

fulldecent opened this issue Sep 1, 2023 · 2 comments

Comments

@fulldecent
Copy link

fulldecent commented Sep 1, 2023

https://ethereum.github.io/eipw/preamble-re-discussions-to/

For EIPs which were already finalized and which have a ID number below XXX?, they should please be exempt from creating a discussion on Ethereum Magicians.

For example, ERC-721 has been thoroughly discussed already and it predates Ethereum Magicians, and many of the current EIP processes. (Fun fact, 721 itself actually set much of how the EIP process currently runs.) Further discussion on standardization is specifically disallowed (it is frozen). Therefore it is not appropriate to require ERC-721 to open an EM thread about standardization.

Yes, this matters practically. Because I do still get a bunch of PRs against 721. Because the idiot who lead authored it allowed a bunch of (nonnormative) typos to slip in, which are being corrected over the years. And those corrections get flagged with this new rule that should not apply.

@Pandapip1
Copy link
Member

How about allowing Final EIPs to use any discussion-to link?

@fulldecent
Copy link
Author

I'm a fan of that.

Then it just our (humans') responsibility to ensure new things do not become final until they have discussion links (and healthy discussion). And I believe we already do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants