From ad933b04262001c62f09588bbbc09c5a70f13a8f Mon Sep 17 00:00:00 2001 From: Khawla <69622217+khawlahssn@users.noreply.github.com> Date: Sat, 22 Jun 2024 12:43:29 +0400 Subject: [PATCH 1/4] =?UTF-8?q?=F0=9F=8E=A8=20=20re-arrange=20status=20in?= =?UTF-8?q?=20flow=20vec?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- eipw-lint/src/lib.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/eipw-lint/src/lib.rs b/eipw-lint/src/lib.rs index 41ad25c6..9229012f 100644 --- a/eipw-lint/src/lib.rs +++ b/eipw-lint/src/lib.rs @@ -326,10 +326,11 @@ pub fn default_lints_enum() -> impl Iterator Date: Sat, 22 Jun 2024 12:46:53 +0400 Subject: [PATCH 2/4] =?UTF-8?q?=E2=9C=85=20update=20too-unstable=20eipv=20?= =?UTF-8?q?test?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../tests/eipv/preamble-requires-too-unstable/expected.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eipw-lint/tests/eipv/preamble-requires-too-unstable/expected.txt b/eipw-lint/tests/eipv/preamble-requires-too-unstable/expected.txt index 892cdffc..d11af739 100644 --- a/eipw-lint/tests/eipv/preamble-requires-too-unstable/expected.txt +++ b/eipw-lint/tests/eipv/preamble-requires-too-unstable/expected.txt @@ -5,4 +5,4 @@ error[preamble-requires-status]: preamble header `requires` contains items not s | ^^^ has a less advanced status | ^^^^^ has a less advanced status | - = help: valid `status` values for this proposal are: `Draft`, `Stagnant` + = help: valid `status` values for this proposal are: `Draft`, `Stagnant`, `Withdrawn` From 84f62ca330b622bc9455310d50373f15fa26beeb Mon Sep 17 00:00:00 2001 From: Khawla <69622217+khawlahssn@users.noreply.github.com> Date: Sat, 22 Jun 2024 12:50:50 +0400 Subject: [PATCH 3/4] =?UTF-8?q?=E2=9C=85=20add=20test=20to=20check=20withd?= =?UTF-8?q?rawn=20status=20rejection?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../eip-1337.md | 3 ++ .../eip-20.md | 3 ++ .../eip-2048.md | 3 ++ .../expected.txt | 7 +++ .../input.md | 48 +++++++++++++++++++ 5 files changed, 64 insertions(+) create mode 100644 eipw-lint/tests/eipv/preamble-requires-no-withdrawn-status/eip-1337.md create mode 100644 eipw-lint/tests/eipv/preamble-requires-no-withdrawn-status/eip-20.md create mode 100644 eipw-lint/tests/eipv/preamble-requires-no-withdrawn-status/eip-2048.md create mode 100644 eipw-lint/tests/eipv/preamble-requires-no-withdrawn-status/expected.txt create mode 100644 eipw-lint/tests/eipv/preamble-requires-no-withdrawn-status/input.md diff --git a/eipw-lint/tests/eipv/preamble-requires-no-withdrawn-status/eip-1337.md b/eipw-lint/tests/eipv/preamble-requires-no-withdrawn-status/eip-1337.md new file mode 100644 index 00000000..1cb066d1 --- /dev/null +++ b/eipw-lint/tests/eipv/preamble-requires-no-withdrawn-status/eip-1337.md @@ -0,0 +1,3 @@ +--- +status: Final +--- diff --git a/eipw-lint/tests/eipv/preamble-requires-no-withdrawn-status/eip-20.md b/eipw-lint/tests/eipv/preamble-requires-no-withdrawn-status/eip-20.md new file mode 100644 index 00000000..576e3b5d --- /dev/null +++ b/eipw-lint/tests/eipv/preamble-requires-no-withdrawn-status/eip-20.md @@ -0,0 +1,3 @@ +--- +status: Last Call +--- diff --git a/eipw-lint/tests/eipv/preamble-requires-no-withdrawn-status/eip-2048.md b/eipw-lint/tests/eipv/preamble-requires-no-withdrawn-status/eip-2048.md new file mode 100644 index 00000000..47017906 --- /dev/null +++ b/eipw-lint/tests/eipv/preamble-requires-no-withdrawn-status/eip-2048.md @@ -0,0 +1,3 @@ +--- +status: Withdrawn +--- diff --git a/eipw-lint/tests/eipv/preamble-requires-no-withdrawn-status/expected.txt b/eipw-lint/tests/eipv/preamble-requires-no-withdrawn-status/expected.txt new file mode 100644 index 00000000..7ee7c44c --- /dev/null +++ b/eipw-lint/tests/eipv/preamble-requires-no-withdrawn-status/expected.txt @@ -0,0 +1,7 @@ +error[preamble-requires-status]: preamble header `requires` contains items not stable enough for a `status` of `Review` + --> input.md:11:20 + | +11 | requires: 20, 1337, 2048 + | ^^^^^ has a less advanced status + | + = help: valid `status` values for this proposal are: `Withdrawn` diff --git a/eipw-lint/tests/eipv/preamble-requires-no-withdrawn-status/input.md b/eipw-lint/tests/eipv/preamble-requires-no-withdrawn-status/input.md new file mode 100644 index 00000000..66445e9d --- /dev/null +++ b/eipw-lint/tests/eipv/preamble-requires-no-withdrawn-status/input.md @@ -0,0 +1,48 @@ +--- +eip: 1 +title: A sample proposal +description: This proposal is a sample that should be considered +author: John Doe (@johndoe), Jenny Doe +discussions-to: https://ethereum-magicians.org/t/hello/1 +status: Review +type: Standards Track +category: Core +created: 2020-01-01 +requires: 20, 1337, 2048 +--- + +## Abstract + +This is the abstract for the EIP. + +## Motivation + +This is the motivation for the EIP. + +## Specification + +This is the specification for the EIP. + +## Rationale + +This is the rationale for the EIP. + +## Backwards Compatibility + +These are the backwards compatibility concerns for the EIP. + +## Test Cases + +These are the test cases for the EIP. + +## Reference Implementation + +This is the implementation for the EIP. + +## Security Considerations + +These are the security considerations for the EIP. + +## Copyright + +Copyright and related rights waived via [CC0](../LICENSE.md). From a3b820ea635a47c5e2bc82e44ee5a2dc2a3f0ee5 Mon Sep 17 00:00:00 2001 From: Khawla <69622217+khawlahssn@users.noreply.github.com> Date: Sat, 22 Jun 2024 12:55:16 +0400 Subject: [PATCH 4/4] =?UTF-8?q?=F0=9F=93=9D=20add=20eipv=20test=20command?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- eipw-lint/tests/eipv/README.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 eipw-lint/tests/eipv/README.md diff --git a/eipw-lint/tests/eipv/README.md b/eipw-lint/tests/eipv/README.md new file mode 100644 index 00000000..79ffe368 --- /dev/null +++ b/eipw-lint/tests/eipv/README.md @@ -0,0 +1,6 @@ +# To run the eipv tests: + +``` +cd eipw-lint +cargo test --all --all-features +```