Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow access to remote signing APIs #170

Open
fubuloubu opened this issue Oct 28, 2019 · 5 comments
Open

Allow access to remote signing APIs #170

fubuloubu opened this issue Oct 28, 2019 · 5 comments

Comments

@fubuloubu
Copy link
Contributor

fubuloubu commented Oct 28, 2019

What was wrong?

eth_sign, eth_signTransaction, and eth_signTypedData RPC APIs are not implemented in eth-tester, which should delegate to the corresponding methods in the eth_account.Account class.

How can it be fixed?

Add access

@pipermerriam
Copy link
Member

I believe that this would actually be more appropriately implemented in the web3 codebase as part of the way that the EthereumTesterProvider delegates requests to different endpoints

https://github.com/ethereum/web3.py/blob/8754a15bf03fc15308376aa9244d5a48f9544271/web3/providers/eth_tester/main.py#L61

@fubuloubu
Copy link
Contributor Author

Fair, I will move this issue there.

@fubuloubu
Copy link
Contributor Author

fubuloubu commented Oct 28, 2019

Actually, eth-tester custodies the keys for these accounts, so I think it might best be implemented here

@fubuloubu fubuloubu reopened this Oct 28, 2019
@pipermerriam
Copy link
Member

👍 I think it would be fine to implement the core of the functionality here and then just do the wiring in web3.

@5h44n
Copy link

5h44n commented Oct 5, 2022

did this ever get implemented?

thanks for this package as well has made testing a breeze 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants