-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example requests and responses are too dummy on JSON-RPC SPEC page #11384
Comments
This issue is stale because it has been open 45 days with no activity. |
Hey @Amit0617! Thanks for posting, and sorry for delays getting back to you. Looks like you're referring to the Any thoughts on how you'd like to see this fixed? |
Yes, my main concern was they are just completely dummy values. While that is not a big issue for someone who is just reviewing and learning about this first time. However, people who will be reading specs and build tooling around it, will try to use those parameters as an example to test their tooling. They will also try to match corresponding responses with it. |
I recently saw, there is a new section added |
@Amit0617 open to these changes if you would like to take this on. I would just er on the side of standardized values kind of like you said (vitalik.eth is used all over the place with other projects I notice for example). |
This issue is stale because it has been open 30 days with no activity. |
Describe the bug
There are various kinds of requests and responses on json-rpc spec page. I understand they are for the purpose of giving structure of request and responses but it would be a good idea that responses are of mentioned request.
Mainly there should be such requests which can give desired kind of responses.
To reproduce
Try eth_getBalance and you would find following response
{"jsonrpc":"2.0","id":1,"result":"0x0"}
Expected behavior
Mentioned response is expected i.e.,
Screenshots
No response
Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional context
No response
Would you like to work on this issue?
The text was updated successfully, but these errors were encountered: