Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update layout spacing on home/hub pages #11464

Closed
TylerAPfledderer opened this issue Oct 18, 2023 · 4 comments
Closed

Update layout spacing on home/hub pages #11464

TylerAPfledderer opened this issue Oct 18, 2023 · 4 comments
Assignees
Labels
dev required This requires developer resources

Comments

@TylerAPfledderer
Copy link
Contributor

TylerAPfledderer commented Oct 18, 2023

Per discussions in #11132 regarding spacing presented from a new hub hero with content below (learn hub page was the example), need to pull a new PR to address the other pages that will have the new heroes.

  • With the home page, we are looking to have the hero image span the entire viewport regardless of screen size. The page layout needs a mini revamp to allow for this.
  • For the remaining hub pages that are not immediately implementing the new hero, update the spacing (especially for mobile) to prep for the future additions.

This PR would also address updating spacing patterns for these pages (i.e. allow a parent component or wrapper control spacing between children)

@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Oct 18, 2023
@TylerAPfledderer
Copy link
Contributor Author

@pettinarip commenting for assignment since this has been previously discussed.

Any other thoughts you have here?

Copy link
Contributor

github-actions bot commented Dec 9, 2023

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Dec 9, 2023
@wackerow wackerow added dev required This requires developer resources and removed Status: Stale This issue is stale because it has been open 30 days with no activity. needs triage 📥 This issue needs triaged before being worked on labels Jun 13, 2024
@wackerow
Copy link
Member

Thanks @TylerAPfledderer!... Sorry for delay here, want to double check if this is still necessary at this point? If so I've assigned you, but if not feel free to just close out.

@TylerAPfledderer
Copy link
Contributor Author

@wackerow going to close out as it is outdated and not necessary at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev required This requires developer resources
Projects
None yet
Development

No branches or pull requests

3 participants
@wackerow @TylerAPfledderer and others