Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attestation rewards outdated #11840

Closed
1 of 2 tasks
tdahar opened this issue Dec 28, 2023 · 0 comments · Fixed by #11842
Closed
1 of 2 tasks

Attestation rewards outdated #11840

tdahar opened this issue Dec 28, 2023 · 0 comments · Fixed by #11842
Labels
bug 🐛 Something isn't working needs triage 📥 This issue needs triaged before being worked on

Comments

@tdahar
Copy link
Contributor

tdahar commented Dec 28, 2023

Describe the bug

Attestation rewards are calculated differently in each fork. Phase0 had a specific calculation, which then changed in Altair.
Since the Altair fork, the attestation rewards calculation has not changed, but on the website, these are still shown as the Phase0 calculation.
https://ethereum.org/en/developers/docs/consensus-mechanisms/pos/attestations/#rewards

I wonder if this should be updated to the latest or if the page should be refactored to support different forks.

To reproduce

  1. Go to 'https://ethereum.org/en/developers/docs/consensus-mechanisms/pos/attestations/#rewards'

Expected behavior

I would expect this page to allow to select which fork to look at or to show the latest calculation.

Screenshots

image

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

I have forked the repository and I have a branch with the latest update. I would really love to contribute and help if possible :)

Would you like to work on this issue?

  • Yes
  • No
@tdahar tdahar added the bug 🐛 Something isn't working label Dec 28, 2023
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working needs triage 📥 This issue needs triaged before being worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant