Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EOA address char count with an example #11877

Closed
aslikaya opened this issue Jan 5, 2024 · 4 comments · Fixed by #13323
Closed

Add EOA address char count with an example #11877

aslikaya opened this issue Jan 5, 2024 · 4 comments · Fixed by #13323
Labels
content 🖋️ This involves copy additions or edits good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help

Comments

@aslikaya
Copy link
Contributor

aslikaya commented Jan 5, 2024

It is stated for the contract accounts but not for EOAs. It is implicit for EOAs - that require additional knowledge for byte conversion. Adding it would make it clear and an example would make it easier to understand.
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Jan 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Feb 20, 2024
@github-actions github-actions bot closed this as completed May 8, 2024
@minimalsm minimalsm reopened this May 9, 2024
@minimalsm minimalsm removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label May 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 9, 2024

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jun 9, 2024
@wackerow wackerow added help wanted Extra attention is needed or someone is needed to help content 🖋️ This involves copy additions or edits good first issue Good item to try if you're new to contributing and removed Status: Stale This issue is stale because it has been open 30 days with no activity. needs triage 📥 This issue needs triaged before being worked on labels Jun 14, 2024
@wackerow
Copy link
Member

I like this suggestion! Opening up for a contributor with the following scope:

  • Edit https://ethereum.org/en/developers/docs/accounts/ within #account-creation adding a section for externally owned accounts (EOAs) have a 42-character address, adding a neutral example
  • Optionally fix "42 character" -> "42-character"
  • Optionally expand on this to clarify it's a 20-byte segment, which is 40 hexadecimal characters, or 42 total characters with the 0x

@Shiva-Sai-ssb Shiva-Sai-ssb mentioned this issue Jul 4, 2024
Merged
@Shiva-Sai-ssb
Copy link
Contributor

Submitted PR for this. @wackerow
Please review it and let me know if any changes required.

@corwintines corwintines mentioned this issue Jul 24, 2024
Merged
@corwintines corwintines mentioned this issue Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content 🖋️ This involves copy additions or edits good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update EOA address info [Fixes #11877] Shiva-Sai-ssb/ethereum-org-website
4 participants
@aslikaya @wackerow @minimalsm @Shiva-Sai-ssb