Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Comments in .env.example #11937

Open
TylerAPfledderer opened this issue Oct 28, 2023 · 8 comments
Open

Update Comments in .env.example #11937

TylerAPfledderer opened this issue Oct 28, 2023 · 8 comments
Labels
good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help refactor ♻️ Changes which don't affect functionality Status: Stale This issue is stale because it has been open 30 days with no activity. tooling 🔧 Changes related to tooling of the project

Comments

@TylerAPfledderer
Copy link
Contributor

TylerAPfledderer commented Oct 28, 2023

Add comments for the set of env variables for the Algolia search in .env.example. Either clearly define a set of keys available to use for the project when testing the functionality with content in the project or supply the test keys provided by the DocSearch docs.

Secondly, update comment to state that .env.example file name needs to be converted to .env.local when in use, per NextJS requirement.

@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Oct 28, 2023
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Dec 15, 2023
@pettinarip pettinarip transferred this issue from ethereum/ethereum-org-fork Jan 16, 2024
@wackerow wackerow added refactor ♻️ Changes which don't affect functionality tooling 🔧 Changes related to tooling of the project and removed Status: Stale This issue is stale because it has been open 30 days with no activity. needs triage 📥 This issue needs triaged before being worked on labels Jun 13, 2024
@wackerow
Copy link
Member

Looks like this is still needed. I'm in favor of just using the test keys provided by DocSearch docs as a fallback.. any foreseeable issues with using this just for testing?

@TylerAPfledderer Happy to assign but also don't want to assume. Pretty well defined task, opening for community in the meantime.

@wackerow wackerow added help wanted Extra attention is needed or someone is needed to help good first issue Good item to try if you're new to contributing labels Jun 13, 2024
@TylerAPfledderer
Copy link
Contributor Author

@wackerow last time I tested this, I saw no issues.

We can leave this open to the community for now.

@corwintines
Copy link
Member

Still open for someone to take :)

@TylerAPfledderer
Copy link
Contributor Author

Point out here that my comment about using .env.local may not actually be necessary here. It is more dependent on project strategy in how we work with the variables depending on environment what .env file Netlify needs to build with.

So no need to change the filename here! :)

Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Aug 10, 2024
@0xshikhar
Copy link

Hey @corwintines , would like to work on this task. Could you clarify the remaining tasks for this issue? Any additional context would be appreciated. Thanks!

@github-actions github-actions bot removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Oct 24, 2024
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help refactor ♻️ Changes which don't affect functionality Status: Stale This issue is stale because it has been open 30 days with no activity. tooling 🔧 Changes related to tooling of the project
Projects
None yet
Development

No branches or pull requests

4 participants