Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create story for DismissableBanner component #13044

Closed
4 tasks
Tracked by #13043
corwintines opened this issue May 27, 2024 · 9 comments · Fixed by #13189 or #13368
Closed
4 tasks
Tracked by #13043

Create story for DismissableBanner component #13044

corwintines opened this issue May 27, 2024 · 9 comments · Fixed by #13189 or #13368
Assignees
Labels
feature ✨ This is enhancing something existing or creating something new good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help

Comments

@corwintines
Copy link
Member

corwintines commented May 27, 2024

Create story tests for DismissableBanner component

Prerequisite

To get yourself up to speed on how we use storybook on ethereum.org, learn more here

What to do

  • Move /src/components/Banners/DismissableBanner.tsx to /src/components/Banners/DismissableBanner/index.tsx
  • Fix any filepath changes to imports for the DismissableBanner component
  • Create story file /src/components/Banners/DismissableBanner/DismissableBanner.stories.tsx
  • Write story testing render of the DismissableBanner component in context of use.
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label May 27, 2024
@corwintines corwintines changed the title DismissableBanner (BugBountyBanner, make sub issue for this) [WIP] DismissableBanner (BugBountyBanner, make sub issue for this) May 27, 2024
@corwintines corwintines changed the title [WIP] DismissableBanner (BugBountyBanner, make sub issue for this) DismissableBanner (BugBountyBanner, make sub issue for this) May 28, 2024
@corwintines corwintines changed the title DismissableBanner (BugBountyBanner, make sub issue for this) Create story for DismissableBanner component May 28, 2024
@wackerow wackerow added feature ✨ This is enhancing something existing or creating something new good first issue Good item to try if you're new to contributing dev required This requires developer resources help wanted Extra attention is needed or someone is needed to help and removed needs triage 📥 This issue needs triaged before being worked on dev required This requires developer resources labels Jun 6, 2024
@wackerow wackerow added this to the 13043 milestone Jun 7, 2024
@wackerow wackerow added good first issue Good item to try if you're new to contributing and removed good first issue Good item to try if you're new to contributing labels Jun 13, 2024
dbarabashh added a commit to dbarabashh/ethereum-org-website that referenced this issue Jun 18, 2024
@wackerow
Copy link
Member

@tutizaraz Again appreciate your enthusiasm to help! Please make sure to comment on an issue to get assigned before starting work on it (it's a frequent cause of duplicating work)

@wackerow
Copy link
Member

Please note that we can only assign someone to an issue after they've commented on it, so I cannot yet assign you here. This also helps us just stay organized so we can visually see who's assigned to different tasks. Thanks!

@corwintines
Copy link
Member Author

As mentioned @tutizaraz, in the future please comment in the issue and get assigned in the future, but appreciate you jumping on this.

I have updated the information on implementation details for this issue. If you don't mind making those changes to fit this criteria in your PR that would be great.

@corwintines
Copy link
Member Author

Trying to assign you and having issues finding you when using your username to assign. Will try assigning again tomorrow, not sure if this is a GitHub thing.

dbarabashh added a commit to dbarabashh/ethereum-org-website that referenced this issue Jun 21, 2024
dbarabashh added a commit to dbarabashh/ethereum-org-website that referenced this issue Jun 21, 2024
@TylerAPfledderer
Copy link
Contributor

@tutizaraz following up here. 😄 It looks like there isn't a comment made by you under this issue. Please provide some kind of comment like "Commenting for assignment" here so @wackerow or @corwintines can properly assign you. I don't think tagging a PR to this issue will work.

By the way, even though your PR is blocked to run checks and tests, I'll still take a moment to review it before a core member can unblock it.

@dbarabashh
Copy link
Contributor

@TylerAPfledderer i couldn't quite understand. @corwintines wasn't able to assign me this task for some reason. he said he'd try again later

And I didn't quite understand what exactly is blocking my pull request.

upd; Commenting for assignment

@TylerAPfledderer
Copy link
Contributor

TylerAPfledderer commented Jun 23, 2024

@TylerAPfledderer i couldn't quite understand. @corwintines wasn't able to assign me this task for some reason. he said he'd try again later

And I didn't quite understand what exactly is blocking my pull request.

upd; Commenting for assignment

All good!

I think Corwin's comment about not being able to assign you still had to do with you not yet commenting here. 😅 The assignment should work now!

You are a first-time contributor to this project, so the PR needs approval from a member to approve running the Github CI checks. My apologies for the lack of clarity. The important thing is that I went ahead and wrote a review. 👍🏼

@dbarabashh
Copy link
Contributor

@TylerAPfledderer oke, thank you for the clarification

dbarabashh added a commit to dbarabashh/ethereum-org-website that referenced this issue Jun 23, 2024
dbarabashh added a commit to dbarabashh/ethereum-org-website that referenced this issue Jun 25, 2024
@wackerow
Copy link
Member

I think Corwin's comment about not being able to assign you still had to do with you not yet commenting here.

Yep! Sorry for confusion @tutizaraz, but we cannot assign someone to an issue if they haven't commented on it yet (even if a PR has been posted for it). Now I was able to 😄

corwintines added a commit that referenced this issue Jul 10, 2024
add story for DismissableBanner component [Fixes #13044]
This was referenced Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ✨ This is enhancing something existing or creating something new good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help
Projects
None yet
4 participants