Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Loading animation on the website. #13600

Open
1 of 2 tasks
Tanishk05 opened this issue Aug 7, 2024 · 5 comments
Open
1 of 2 tasks

No Loading animation on the website. #13600

Tanishk05 opened this issue Aug 7, 2024 · 5 comments
Assignees
Labels
bug 🐛 Something isn't working design required 🎨 This involves design changes dev required This requires developer resources request for comments 🗣️ A request for comments has been made; discussion and input is encouraged Status: Stale This issue is stale because it has been open 30 days with no activity.

Comments

@Tanishk05
Copy link

Describe the bug

When I had first opened the site and click on any of the button, lets say explore button on the home page it waits for sometimes and then loads the page, but during that time I was not able to tell whats happening whether it is processing or not or my internet is slow.

To reproduce

  1. Go to 'https://ethereum.org/en/'
  2. Click on 'Explore Ethereum'
  3. See error

Expected behavior

Its expected behavior is to show some kind of loading animation to tell users that something is happening and the site is not stuck.

Screenshots

See this video

Screencast.from.2024-08-07.23-21-12.mp4

In this, when I click on the buttons or the links down it takes some time to take to the destination.

Lets say there is person whose internet is not that good, he may feel like stuck so this issue needs to be fixed.

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@Tanishk05 Tanishk05 added the bug 🐛 Something isn't working label Aug 7, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Aug 7, 2024
@wackerow
Copy link
Member

wackerow commented Aug 8, 2024

Hey @Tanishk05, appreciate you noting your experience here. Few things here about updates already in progress:

  • Performance improvements: the team currently has had a focus on identifying and solving performance issues especially for those with lower bandwidth connections, or weaker devices. A large part of this is the current migration to using shadcn using tailwindcss, with the goal to offer improved loading times. @pettinarip leading these efforts
  • Homepage revamp: another upgrade being built in parallel which will bring several changes to the homepage specifically. Through this, performance is also being kept in mind, and there has been discussion similar to the issue you've raised around minimizing the initial load time, potentially using more lazy loading of larger content (ie hero image) and using some css coloration/animation as a filler.

cc: @pettinarip Not sure if I missed it, but do we have another issue tracking the performance changes specifically? Can leave this issue open for now as a tracking item if we don't have anything better...
@Tanishk05 I love that you expressed interest in working on this! As noted above it's a complicated issue that already has a few solutions in flight, so I'd say please feel free to add to the discussion here, or on Discord, but in the meantime going to assign this to @pettinarip and myself.

You mentioned animations, did you have any specific thoughts on how you'd like to see the homepage be presented while loading?

@wackerow wackerow added design required 🎨 This involves design changes dev required This requires developer resources request for comments 🗣️ A request for comments has been made; discussion and input is encouraged and removed needs triage 📥 This issue needs triaged before being worked on labels Aug 8, 2024
@Tanishk05
Copy link
Author

By seeing Ethereum logo

Screenshot from 2024-08-08 22-50-35

The animation should like, there is two parts of it, so when the animation starts they move away, come close and rotate then repeat.

@Tanishk05
Copy link
Author

Modern Animation

You can use above animation like when someone click on a button, cursor turns into above animation and when the page is loaded it turns back to normal, instead of displaying the animation on the whole page.

@pettinarip
Copy link
Member

Hey @Tanishk05, appreciate you noting your experience here. Few things here about updates already in progress:

  • Performance improvements: the team currently has had a focus on identifying and solving performance issues especially for those with lower bandwidth connections, or weaker devices. A large part of this is the current migration to using shadcn using tailwindcss, with the goal to offer improved loading times. @pettinarip leading these efforts
  • Homepage revamp: another upgrade being built in parallel which will bring several changes to the homepage specifically. Through this, performance is also being kept in mind, and there has been discussion similar to the issue you've raised around minimizing the initial load time, potentially using more lazy loading of larger content (ie hero image) and using some css coloration/animation as a filler.

cc: @pettinarip Not sure if I missed it, but do we have another issue tracking the performance changes specifically? Can leave this issue open for now as a tracking item if we don't have anything better... @Tanishk05 I love that you expressed interest in working on this! As noted above it's a complicated issue that already has a few solutions in flight, so I'd say please feel free to add to the discussion here, or on Discord, but in the meantime going to assign this to @pettinarip and myself.

You mentioned animations, did you have any specific thoughts on how you'd like to see the homepage be presented while loading?

There is no public issue to track performance issues / fixes at the moment.

IMO we should wait and see the end results of the shadcn & homepage migrations. If we still find that the UX is still bad for slow connections/devices, we should implement a change to the UI to make it obvious.

We discussed this before and one suggestion was to implement a progress bar at the top of the page for page transitions. This idea lets the user know about the lack of interactivity while the content is still visible and the native elements (links) still work from the first render.

Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working design required 🎨 This involves design changes dev required This requires developer resources request for comments 🗣️ A request for comments has been made; discussion and input is encouraged Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Development

No branches or pull requests

3 participants